Re: RFR: 8247666: Support Lambda proxy classes in static CDS archive [v9]

2020-10-19 Thread Calvin Cheung
On Mon, 19 Oct 2020 16:56:19 GMT, Ioi Lam wrote: >> Calvin Cheung has updated the pull request incrementally with one additional >> commit since the last revision: >> >> store symbolic name of ref kind (e.g. REF_invokeStatic) in classlist > > LGTM @iklam and @mlchung, thanks again for the re

Re: RFR: 8247666: Support Lambda proxy classes in static CDS archive [v10]

2020-10-19 Thread Calvin Cheung
> Following up on archiving lambda proxy classes in dynamic CDS archive > ([JDK-8198698](https://bugs.openjdk.java.net/browse/JDK-8198698)), this RFE > adds the functionality of archiving of > lambda proxy classes in static CDS archive. > When the -XX:DumpLoadedClassList is enabled, the constant p

Re: RFR: 8247666: Support Lambda proxy classes in static CDS archive [v9]

2020-10-19 Thread Ioi Lam
On Mon, 19 Oct 2020 16:04:31 GMT, Calvin Cheung wrote: >> Following up on archiving lambda proxy classes in dynamic CDS archive >> ([JDK-8198698](https://bugs.openjdk.java.net/browse/JDK-8198698)), this RFE >> adds the functionality of archiving of >> lambda proxy classes in static CDS archive.

Re: RFR: 8247666: Support Lambda proxy classes in static CDS archive [v9]

2020-10-19 Thread Mandy Chung
On Mon, 19 Oct 2020 16:04:31 GMT, Calvin Cheung wrote: >> Following up on archiving lambda proxy classes in dynamic CDS archive >> ([JDK-8198698](https://bugs.openjdk.java.net/browse/JDK-8198698)), this RFE >> adds the functionality of archiving of >> lambda proxy classes in static CDS archive.

Re: RFR: 8247666: Support Lambda proxy classes in static CDS archive [v9]

2020-10-19 Thread Calvin Cheung
> Following up on archiving lambda proxy classes in dynamic CDS archive > ([JDK-8198698](https://bugs.openjdk.java.net/browse/JDK-8198698)), this RFE > adds the functionality of archiving of > lambda proxy classes in static CDS archive. > When the -XX:DumpLoadedClassList is enabled, the constant p

Re: RFR: 8247666: Support Lambda proxy classes in static CDS archive [v5]

2020-10-16 Thread Calvin Cheung
On Fri, 16 Oct 2020 21:25:04 GMT, Mandy Chung wrote: >> `@lambda-proxy LambHello run ()Ljava/lang/Runnable; ()V REF_invokeStatic >> LambHello lambda$main$0 ()V ()V` >> means >> `@lambda-proxy >>     >> ` >> It is a symbolic representation of a invoke dynamic constant pool entry. >> public

Re: RFR: 8247666: Support Lambda proxy classes in static CDS archive [v5]

2020-10-16 Thread Mandy Chung
On Wed, 14 Oct 2020 16:24:47 GMT, Calvin Cheung wrote: >>> `@lambda-proxy: LambHello run ()Ljava/lang/Runnable; ()V 6 LambHello >>> lambda$main$0 ()V ()V` >> >> Can you explain the format? > > `@lambda-proxy LambHello run ()Ljava/lang/Runnable; ()V REF_invokeStatic > LambHello lambda$main$0 (

Re: RFR: 8247666: Support Lambda proxy classes in static CDS archive [v8]

2020-10-16 Thread Calvin Cheung
> Following up on archiving lambda proxy classes in dynamic CDS archive > ([JDK-8198698](https://bugs.openjdk.java.net/browse/JDK-8198698)), this RFE > adds the functionality of archiving of > lambda proxy classes in static CDS archive. > When the -XX:DumpLoadedClassList is enabled, the constant p

Re: RFR: 8247666: Support Lambda proxy classes in static CDS archive [v7]

2020-10-15 Thread Calvin Cheung
> Following up on archiving lambda proxy classes in dynamic CDS archive > ([JDK-8198698](https://bugs.openjdk.java.net/browse/JDK-8198698)), this RFE > adds the functionality of archiving of > lambda proxy classes in static CDS archive. > When the -XX:DumpLoadedClassList is enabled, the constant p

Re: RFR: 8247666: Support Lambda proxy classes in static CDS archive [v6]

2020-10-15 Thread Calvin Cheung
> Following up on archiving lambda proxy classes in dynamic CDS archive > ([JDK-8198698](https://bugs.openjdk.java.net/browse/JDK-8198698)), this RFE > adds the functionality of archiving of > lambda proxy classes in static CDS archive. > When the -XX:DumpLoadedClassList is enabled, the constant p

Re: RFR: 8247666: Support Lambda proxy classes in static CDS archive [v5]

2020-10-15 Thread Calvin Cheung
On Tue, 13 Oct 2020 23:59:38 GMT, Ioi Lam wrote: >> Calvin Cheung has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now >> contains ten commits: >> - fix minimal vm build issues >> - Merge branch 'master' into 8247666 >> - Merge branch 'master

Re: RFR: 8247666: Support Lambda proxy classes in static CDS archive [v5]

2020-10-14 Thread Calvin Cheung
On Wed, 14 Oct 2020 01:44:05 GMT, Mandy Chung wrote: >> Changes requested by iklam (Reviewer). > >> `@lambda-proxy: LambHello run ()Ljava/lang/Runnable; ()V 6 LambHello >> lambda$main$0 ()V ()V` > > Can you explain the format? `@lambda-proxy LambHello run ()Ljava/lang/Runnable; ()V REF_invoke

Re: RFR: 8247666: Support Lambda proxy classes in static CDS archive [v5]

2020-10-13 Thread Mandy Chung
On Wed, 14 Oct 2020 00:40:14 GMT, Ioi Lam wrote: >> Calvin Cheung has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now >> contains ten commits: >> - fix minimal vm build issues >> - Merge branch 'master' into 8247666 >> - Merge branch 'master

Re: RFR: 8247666: Support Lambda proxy classes in static CDS archive [v5]

2020-10-13 Thread Ioi Lam
On Tue, 13 Oct 2020 23:08:22 GMT, Calvin Cheung wrote: >> Following up on archiving lambda proxy classes in dynamic CDS archive >> ([JDK-8198698](https://bugs.openjdk.java.net/browse/JDK-8198698)), this RFE >> adds the functionality of archiving of >> lambda proxy classes in static CDS archive.

Re: RFR: 8247666: Support Lambda proxy classes in static CDS archive [v5]

2020-10-13 Thread Calvin Cheung
> Following up on archiving lambda proxy classes in dynamic CDS archive > ([JDK-8198698](https://bugs.openjdk.java.net/browse/JDK-8198698)), this RFE > adds the functionality of archiving of > lambda proxy classes in static CDS archive. > When the -XX:DumpLoadedClassList is enabled, the constant p

RFR: 8247666: Support Lambda proxy classes in static CDS archive

2020-09-25 Thread Calvin Cheung
Following up on archiving lambda proxy classes in dynamic CDS archive ([JDK-8198698](https://bugs.openjdk.java.net/browse/JDK-8198698)), this RFE adds the functionality of archiving of lambda proxy classes in static CDS archive. When the -XX:DumpLoadedClassList is enabled, the constant pool index