On Fri, 24 Sep 2021 11:28:09 GMT, Masanori Yano wrote:
> Could you please review the 8250678 bug fixes?
>
> The `parse` method of ModuleDescriptor.Version class behaves incorrectly when
> the input string contains consecutive delimiters.
>
> The `parse` method treats strings as three
On Fri, 24 Sep 2021 11:28:09 GMT, Masanori Yano wrote:
> Could you please review the 8250678 bug fixes?
>
> The `parse` method of ModuleDescriptor.Version class behaves incorrectly when
> the input string contains consecutive delimiters.
>
> The `parse` method treats strings as three
On Fri, 5 Nov 2021 16:51:02 GMT, Mandy Chung wrote:
> I would suggest to create a separate issue to follow up the spec
> clarification and keep this PR to fix the implementation.
>
> The version parsing code is tricky. The fix is straight-forward, just moving
> the check of the delimiters as
On Fri, 24 Sep 2021 11:28:09 GMT, Masanori Yano wrote:
> Could you please review the 8250678 bug fixes?
>
> The `parse` method of ModuleDescriptor.Version class behaves incorrectly when
> the input string contains consecutive delimiters.
>
> The `parse` method treats strings as three
On Fri, 24 Sep 2021 11:28:09 GMT, Masanori Yano wrote:
> Could you please review the 8250678 bug fixes?
>
> The `parse` method of ModuleDescriptor.Version class behaves incorrectly when
> the input string contains consecutive delimiters.
>
> The `parse` method treats strings as three
On Tue, 2 Nov 2021 20:09:21 GMT, Mandy Chung wrote:
> I reviewed the change. It is reasonable to fix the parsing of the pre-release
> version and the build version be consistent with parsing of the version
> number which currently skips consecutive delimiters.
>
> The spec is unclear on
On Fri, 24 Sep 2021 11:28:09 GMT, Masanori Yano wrote:
> Could you please review the 8250678 bug fixes?
>
> The `parse` method of ModuleDescriptor.Version class behaves incorrectly when
> the input string contains consecutive delimiters.
>
> The `parse` method treats strings as three
On Wed, 6 Oct 2021 18:40:36 GMT, Mark Reinhold wrote:
>> @mbreinhold Could you comment on this pull request?
>
>> @mbreinhold Could you comment on this pull request?
>
> This is somewhat tricky code. I’ll take a look, but give me a few days.
@mbreinhold @AlanBateman Are you aware of my
On Wed, 6 Oct 2021 18:40:36 GMT, Mark Reinhold wrote:
>> @mbreinhold Could you comment on this pull request?
>
>> @mbreinhold Could you comment on this pull request?
>
> This is somewhat tricky code. I’ll take a look, but give me a few days.
@mbreinhold @AlanBateman Could you please reply to
On Mon, 27 Sep 2021 08:22:02 GMT, Alan Bateman wrote:
>> Could you please review the 8250678 bug fixes?
>>
>> The `parse` method of ModuleDescriptor.Version class behaves incorrectly
>> when the input string contains consecutive delimiters.
>>
>> The `parse` method treats strings as three
On Wed, 6 Oct 2021 18:40:36 GMT, Mark Reinhold wrote:
>> @mbreinhold Could you comment on this pull request?
>
>> @mbreinhold Could you comment on this pull request?
>
> This is somewhat tricky code. I’ll take a look, but give me a few days.
@mbreinhold (@AlanBateman ) Could you tell me how
On Wed, 6 Oct 2021 18:40:36 GMT, Mark Reinhold wrote:
>> @mbreinhold Could you comment on this pull request?
>
>> @mbreinhold Could you comment on this pull request?
>
> This is somewhat tricky code. I’ll take a look, but give me a few days.
@mbreinhold I waited for about a week, but I haven't
On Thu, 30 Sep 2021 11:26:12 GMT, Masanori Yano wrote:
> @mbreinhold Could you comment on this pull request?
This is somewhat tricky code. I’ll take a look, but give me a few days.
-
PR: https://git.openjdk.java.net/jdk/pull/5679
On Mon, 27 Sep 2021 08:22:02 GMT, Alan Bateman wrote:
>> Could you please review the 8250678 bug fixes?
>>
>> The `parse` method of ModuleDescriptor.Version class behaves incorrectly
>> when the input string contains consecutive delimiters.
>>
>> The `parse` method treats strings as three
On Fri, 24 Sep 2021 11:28:09 GMT, Masanori Yano wrote:
> Could you please review the 8250678 bug fixes?
>
> The `parse` method of ModuleDescriptor.Version class behaves incorrectly when
> the input string contains consecutive delimiters.
>
> The `parse` method treats strings as three
On Fri, 24 Sep 2021 11:28:09 GMT, Masanori Yano wrote:
> Could you please review the 8250678 bug fixes?
>
> The `parse` method of ModuleDescriptor.Version class behaves incorrectly when
> the input string contains consecutive delimiters.
>
> The `parse` method treats strings as three
Could you please review the 8250678 bug fixes?
The `parse` method of ModuleDescriptor.Version class behaves incorrectly when
the input string contains consecutive delimiters.
The `parse` method treats strings as three sections, but the parsing method
differs between the method for the version
17 matches
Mail list logo