Re: RFR: 8251397: Add release fence to ClassValueMap constructor [v2]

2020-09-14 Thread Severin Gehwolf
On Mon, 14 Sep 2020 12:59:00 GMT, Galder Zamarreño wrote: >> Note that I've opened >> [SKARA-633](https://bugs.openjdk.java.net/browse/SKARA-633) for >> pre-population of the commit >> message with an appropriate summary. > > Add release fence to ClassValueMap constructor. > > * Release fence

Re: RFR: 8251397: Add release fence to ClassValueMap constructor [v2]

2020-09-14 Thread Galder Zamarreño
> * Release fence guarantees that cacheArray field will published with a > non-null value. > * Without this fix, CacheValueMap.cacheArray can sometimes be seen as null. > > This is a follow up to @PaulSandoz's feedback > [here](https://mail.openjdk.java.net/pipermail/core-libs-dev/2020-August/068

Re: RFR: 8251397: Add release fence to ClassValueMap constructor [v2]

2020-09-14 Thread Galder Zamarreño
On Mon, 14 Sep 2020 12:04:30 GMT, Severin Gehwolf wrote: >> @galderz Now it's the other way round. Commit message the bot mentions >> [here](https://github.com/openjdk/jdk/pull/94#issuecomment-691478179) should >> be something like this: >> 8251397: NPE on ClassValue.ClassValueMap.cacheArray >>