On Tue, 13 Oct 2020 21:56:31 GMT, Marcono1234
wrote:
>> Roger Riggs has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Various code review comments, rename UpperCase and LowerCase methods to
>> match Character, remove unnecessary Class
On Wed, 14 Oct 2020 13:46:59 GMT, Daniel Fuchs wrote:
>> Its a bit of a space/time trade-off. And the balance point will change if
>> the class is converted in the future to a
>> Valhalla primitive class. At this point it looks to me like a premature
>> optimization.
>
> OK - but just to
On Wed, 14 Oct 2020 09:53:23 GMT, Daniel Fuchs wrote:
>> Roger Riggs has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Various code review comments, rename UpperCase and LowerCase methods to
>> match Character, remove unnecessary Class
On Wed, 14 Oct 2020 13:38:51 GMT, Roger Riggs wrote:
>> src/java.net.http/share/classes/jdk/internal/net/http/common/Utils.java line
>> 1116:
>>
>>> 1114: }
>>> 1115:
>>> 1116: HexFormat format = HexFormat.of().withUpperCase();
>>
>> Should/can this be a static final field in
On Wed, 14 Oct 2020 09:28:25 GMT, Daniel Fuchs wrote:
>> Roger Riggs has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Various code review comments, rename UpperCase and LowerCase methods to
>> match Character, remove unnecessary Class
On Tue, 13 Oct 2020 19:51:30 GMT, Roger Riggs wrote:
>> java.util.HexFormat utility:
>>
>> - Format and parse hexadecimal strings, with parameters for delimiter,
>> prefix, suffix and upper/lowercase
>> - Static factories and builder methods to create HexFormat copies with
>> modified
On Tue, 13 Oct 2020 19:51:30 GMT, Roger Riggs wrote:
>> java.util.HexFormat utility:
>>
>> - Format and parse hexadecimal strings, with parameters for delimiter,
>> prefix, suffix and upper/lowercase
>> - Static factories and builder methods to create HexFormat copies with
>> modified
On Tue, 13 Oct 2020 16:24:32 GMT, Roger Riggs wrote:
>> src/java.base/share/classes/java/util/HexFormat.java line 1015:
>>
>>> 1013: */
>>> 1014: @Override
>>> 1015: public String toString() {
>>
>> Might be useful to also include the class name?
>
> The caller may need to provide
On Tue, 13 Oct 2020 19:51:30 GMT, Roger Riggs wrote:
>> java.util.HexFormat utility:
>>
>> - Format and parse hexadecimal strings, with parameters for delimiter,
>> prefix, suffix and upper/lowercase
>> - Static factories and builder methods to create HexFormat copies with
>> modified
On Tue, 13 Oct 2020 16:15:51 GMT, Roger Riggs wrote:
>> test/jdk/java/util/HexFormat/HexFormatTest.java line 406:
>>
>>> 404:
>>> 405: int byteVal = hex.fromHexDigits(byteStr);
>>> 406: assert(byteStr.equals("7f"));
>>
>> Why use regular `assert` statements in this test
> java.util.HexFormat utility:
>
> - Format and parse hexadecimal strings, with parameters for delimiter,
> prefix, suffix and upper/lowercase
> - Static factories and builder methods to create HexFormat copies with
> modified parameters.
> - Consistent naming of methods for conversion of
11 matches
Mail list logo
