Re: RFR: 8253321: java.util.Locale.LanguageRange#equals is inconsistent after calling hashCode [v2]

2020-09-19 Thread Roger Riggs
On Sat, 19 Sep 2020 01:36:38 GMT, Naoto Sato wrote: >> Hi, >> >> Please review the fix to JDK-8253321. As in the issue, uninitialized >> (cached) hash code was incorrectly referenced in >> equals() method. Removing it will correct the problem. Also, unrelated to >> the issue, I fixed a

Re: RFR: 8253321: java.util.Locale.LanguageRange#equals is inconsistent after calling hashCode [v2]

2020-09-18 Thread Joe Wang
On Sat, 19 Sep 2020 01:36:38 GMT, Naoto Sato wrote: >> Hi, >> >> Please review the fix to JDK-8253321. As in the issue, uninitialized >> (cached) hash code was incorrectly referenced in >> equals() method. Removing it will correct the problem. Also, unrelated to >> the issue, I fixed a

Re: RFR: 8253321: java.util.Locale.LanguageRange#equals is inconsistent after calling hashCode [v2]

2020-09-18 Thread Naoto Sato
On Sat, 19 Sep 2020 01:19:04 GMT, Joe Wang wrote: >> Naoto Sato has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Addressing Joe's comments > > Marked as reviewed by joehw (Reviewer). > Also, copyright year may need to be updated to 2020

Re: RFR: 8253321: java.util.Locale.LanguageRange#equals is inconsistent after calling hashCode [v2]

2020-09-18 Thread Naoto Sato
> Hi, > > Please review the fix to JDK-8253321. As in the issue, uninitialized (cached) > hash code was incorrectly referenced in > equals() method. Removing it will correct the problem. Also, unrelated to the > issue, I fixed a parameter description in > a private method. Naoto Naoto Sato

Re: RFR: 8253321: java.util.Locale.LanguageRange#equals is inconsistent after calling hashCode

2020-09-18 Thread Joe Wang
On Fri, 18 Sep 2020 23:26:39 GMT, Naoto Sato wrote: > Hi, > > Please review the fix to JDK-8253321. As in the issue, uninitialized (cached) > hash code was incorrectly referenced in > equals() method. Removing it will correct the problem. Also, unrelated to the > issue, I fixed a parameter

Re: RFR: 8253321: java.util.Locale.LanguageRange#equals is inconsistent after calling hashCode

2020-09-18 Thread Joe Wang
On Fri, 18 Sep 2020 23:26:39 GMT, Naoto Sato wrote: > Hi, > > Please review the fix to JDK-8253321. As in the issue, uninitialized (cached) > hash code was incorrectly referenced in > equals() method. Removing it will correct the problem. Also, unrelated to the > issue, I fixed a parameter

RFR: 8253321: java.util.Locale.LanguageRange#equals is inconsistent after calling hashCode

2020-09-18 Thread Naoto Sato
Hi, Please review the fix to JDK-8253321. As in the issue, uninitialized (cached) hash code was incorrectly referenced in equals() method. Removing it will correct the problem. Also, unrelated to the issue, I fixed a parameter description in a private method. Naoto - Commit