Re: RFR: 8253702: BigSur java/lang/System/OsVersionTest.java: 10.16 != 11.0 [v3]

2021-02-11 Thread Kevin Rushforth
On Thu, 11 Feb 2021 19:23:55 GMT, Roger Riggs wrote: >> On Mac Os X, the OSVersionTest detected a difference in the version number >> reported in the os.version property >> and the version number provided by `sw_vers -productVersion`. >> >> When the java runtime is built with XCode 11.3, the

Re: RFR: 8253702: BigSur java/lang/System/OsVersionTest.java: 10.16 != 11.0 [v3]

2021-02-11 Thread Brian Burkhalter
On Thu, 11 Feb 2021 19:23:55 GMT, Roger Riggs wrote: >> On Mac Os X, the OSVersionTest detected a difference in the version number >> reported in the os.version property >> and the version number provided by `sw_vers -productVersion`. >> >> When the java runtime is built with XCode 11.3, the

Re: RFR: 8253702: BigSur java/lang/System/OsVersionTest.java: 10.16 != 11.0 [v3]

2021-02-11 Thread Roger Riggs
> On Mac Os X, the OSVersionTest detected a difference in the version number > reported in the os.version property > and the version number provided by `sw_vers -productVersion`. > > When the java runtime is built with XCode 11.3, the os.version is reported as > 10.16 > though the current

Re: RFR: 8253702: BigSur java/lang/System/OsVersionTest.java: 10.16 != 11.0 [v2]

2021-02-11 Thread Roger Riggs
On Thu, 11 Feb 2021 19:09:52 GMT, Kevin Rushforth wrote: >> src/java.base/macosx/native/libjava/java_props_macosx.c line 262: >> >>> 260: // Copy out the char* >>> 261: osVersionCStr = strdup([nsVerStr UTF8String]); >>> 262: } else if

Re: RFR: 8253702: BigSur java/lang/System/OsVersionTest.java: 10.16 != 11.0

2021-02-11 Thread Kevin Rushforth
On Thu, 11 Feb 2021 17:14:35 GMT, Roger Riggs wrote: > On Mac Os X, the OSVersionTest detected a difference in the version number > reported in the os.version property > and the version number provided by `sw_vers -productVersion`. > > When the java runtime is built with XCode 11.3, the

Re: RFR: 8253702: BigSur java/lang/System/OsVersionTest.java: 10.16 != 11.0 [v2]

2021-02-11 Thread Kevin Rushforth
On Thu, 11 Feb 2021 18:53:08 GMT, Kevin Rushforth wrote: >> Roger Riggs has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Correct double-negative in 'other than 10.16' > > src/java.base/macosx/native/libjava/java_props_macosx.c line 262:

Re: RFR: 8253702: BigSur java/lang/System/OsVersionTest.java: 10.16 != 11.0 [v2]

2021-02-11 Thread Kevin Rushforth
On Thu, 11 Feb 2021 18:34:54 GMT, Roger Riggs wrote: >> On Mac Os X, the OSVersionTest detected a difference in the version number >> reported in the os.version property >> and the version number provided by `sw_vers -productVersion`. >> >> When the java runtime is built with XCode 11.3, the

Re: RFR: 8253702: BigSur java/lang/System/OsVersionTest.java: 10.16 != 11.0 [v2]

2021-02-11 Thread Roger Riggs
> On Mac Os X, the OSVersionTest detected a difference in the version number > reported in the os.version property > and the version number provided by `sw_vers -productVersion`. > > When the java runtime is built with XCode 11.3, the os.version is reported as > 10.16 > though the current

Re: RFR: 8253702: BigSur java/lang/System/OsVersionTest.java: 10.16 != 11.0

2021-02-11 Thread Kevin Rushforth
On Thu, 11 Feb 2021 17:50:20 GMT, Brian Burkhalter wrote: >> It's a double negative, unless I'm reading it incorrectly: "other than >> pre-10.16" I interpret as "not pre-10.16" or "10.16". > > `// Copy out the char* if running on version 10.x[.y], where x < 16` ? It will also do it if running

Re: RFR: 8253702: BigSur java/lang/System/OsVersionTest.java: 10.16 != 11.0

2021-02-11 Thread Brian Burkhalter
On Thu, 11 Feb 2021 17:49:09 GMT, Kevin Rushforth wrote: >> So the words "other than" are too subtle? > > It's a double negative, unless I'm reading it incorrectly: "other than > pre-10.16" I interpret as "not pre-10.16" or "10.16". `// Copy out the char* if running on version 10.x, where x <

Re: RFR: 8253702: BigSur java/lang/System/OsVersionTest.java: 10.16 != 11.0

2021-02-11 Thread Kevin Rushforth
On Thu, 11 Feb 2021 17:46:06 GMT, Roger Riggs wrote: >> @kevinrushforth I think you are correct. This is actually mea culpa I think >> as I had provided in a Slack thread a failed attempt at a patch for this >> which contained this comment. > > So the words "other than" are too subtle? It's a

Re: RFR: 8253702: BigSur java/lang/System/OsVersionTest.java: 10.16 != 11.0

2021-02-11 Thread Roger Riggs
On Thu, 11 Feb 2021 17:38:42 GMT, Brian Burkhalter wrote: >> src/java.base/macosx/native/libjava/java_props_macosx.c line 250: >> >>> 248: >>> 249: NSString *nsVerStr; >>> 250: // Copy out the char* if running on version other than >>> pre-10.16 Mac OS (10.16 == 11.x) >> >>

Re: RFR: 8253702: BigSur java/lang/System/OsVersionTest.java: 10.16 != 11.0

2021-02-11 Thread Brian Burkhalter
On Thu, 11 Feb 2021 17:31:34 GMT, Kevin Rushforth wrote: >> On Mac Os X, the OSVersionTest detected a difference in the version number >> reported in the os.version property >> and the version number provided by `sw_vers -productVersion`. >> >> When the java runtime is built with XCode 11.3,

Re: RFR: 8253702: BigSur java/lang/System/OsVersionTest.java: 10.16 != 11.0

2021-02-11 Thread Kevin Rushforth
On Thu, 11 Feb 2021 17:14:35 GMT, Roger Riggs wrote: > On Mac Os X, the OSVersionTest detected a difference in the version number > reported in the os.version property > and the version number provided by `sw_vers -productVersion`. > > When the java runtime is built with XCode 11.3, the

RFR: 8253702: BigSur java/lang/System/OsVersionTest.java: 10.16 != 11.0

2021-02-11 Thread Roger Riggs
On Mac Os X, the OSVersionTest detected a difference in the version number reported in the os.version property and the version number provided by `sw_vers -productVersion`. When the java runtime is built with XCode 11.3, the os.version is reported as 10.16 though the current version numbering