Re: RFR: 8254782: Fix benchmark issues in java/lang/StringIndexOfChar.java benchmark [v2]

2020-10-29 Thread Claes Redestad
On Thu, 29 Oct 2020 00:59:56 GMT, Jason Tatton wrote: >> Please review the improvements which I have made to the >> java/lang/StringIndexOfChar.java jmh benchmark. Please let me know if any >> further improvements are required. >> >> Thanks, >> Jason > > Jason Tatton has updated the pull requ

Re: RFR: 8254782: Fix benchmark issues in java/lang/StringIndexOfChar.java benchmark [v2]

2020-10-28 Thread Aleksey Shipilev
On Thu, 29 Oct 2020 00:59:56 GMT, Jason Tatton wrote: >> Please review the improvements which I have made to the >> java/lang/StringIndexOfChar.java jmh benchmark. Please let me know if any >> further improvements are required. >> >> Thanks, >> Jason > > Jason Tatton has updated the pull requ

Re: RFR: 8254782: Fix benchmark issues in java/lang/StringIndexOfChar.java benchmark [v2]

2020-10-28 Thread Jason Tatton
> Please review the improvements which I have made to the > java/lang/StringIndexOfChar.java jmh benchmark. Please let me know if any > further improvements are required. > > Thanks, > Jason Jason Tatton has updated the pull request incrementally with one additional commit since the last revis

Re: RFR: 8254782: Fix benchmark issues in java/lang/StringIndexOfChar.java benchmark [v2]

2020-10-28 Thread Jason Tatton
On Wed, 28 Oct 2020 22:44:37 GMT, Claes Redestad wrote: >> Jason Tatton has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Adjusted benchmark to use BlackHole and improved String array syntax as >> advised > > test/micro/org/openjdk/bench/

Re: RFR: 8254782: Fix benchmark issues in java/lang/StringIndexOfChar.java benchmark

2020-10-28 Thread Claes Redestad
On Wed, 28 Oct 2020 21:59:53 GMT, Jason Tatton wrote: > Please review the improvements which I have made to the > java/lang/StringIndexOfChar.java jmh benchmark. Please let me know if any > further improvements are required. > > Thanks, > Jason Looks OK. FWIW the current looping scheme look

RFR: 8254782: Fix benchmark issues in java/lang/StringIndexOfChar.java benchmark

2020-10-28 Thread Jason Tatton
Please review the improvements which I have made to the java/lang/StringIndexOfChar.java jmh benchmark. Please let me know if any further improvements are required. Thanks, Jason - Commit messages: - 8254782 Changes: https://git.openjdk.java.net/jdk/pull/918/files Webrev: https: