On Fri, 20 Nov 2020 03:27:54 GMT, Mandy Chung wrote:
>> Good point -- case added.
>
> Looks good.
testWithAddExportsInManifest create an executable JAR with "Add-Exports:
java.base/sun.security.x509" in the manifest. It runs it twice, once without
any options, the second with --illegal-access=
Hi Alan,
On 20/11/2020 6:04 pm, Alan Bateman wrote:
On Fri, 20 Nov 2020 07:33:50 GMT, David Holmes wrote:
I'm somewhat surprised by the extent of the other changes given the basic
change here is to deprecate the option and change its default. I literally
expected to see only 2 simple change
On Fri, 20 Nov 2020 07:33:50 GMT, David Holmes wrote:
> I'm somewhat surprised by the extent of the other changes given the basic
> change here is to deprecate the option and change its default. I literally
> expected to see only 2 simple changes to the functional code: the deprecation
> warni
On Thu, 19 Nov 2020 23:08:21 GMT, Mark Reinhold wrote:
>> Please review this implementation of JEP 396
>> (https://openjdk.java.net/jeps/396).
>> Alan Bateman is the original author; I’ve credited him in the commit
>> metadata.
>> Passes tiers 1-3 on {linux,macos,windows}-x64 and linux-aarch64.
On Thu, 19 Nov 2020 23:03:54 GMT, Mark Reinhold wrote:
>> test/jdk/tools/launcher/modules/illegalaccess/IllegalAccessTest.java line
>> 387:
>>
>>> 385: "--illegal-access=permit");
>>> 386: }
>>> 387:
>>
>> I see `setAccessibleNonPublicMemberExportedPackage` test case testi
> Please review this implementation of JEP 396
> (https://openjdk.java.net/jeps/396).
> Alan Bateman is the original author; I’ve credited him in the commit metadata.
> Passes tiers 1-3 on {linux,macos,windows}-x64 and linux-aarch64.
Mark Reinhold has updated the pull request incrementally with o
On Thu, 19 Nov 2020 19:51:59 GMT, Mandy Chung wrote:
>> Mark Reinhold has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Add "Add-Exports" case for the
>> setAccessibleNonPublicMemberNonExportedPackage test
>
> test/jdk/tools/launcher/modu
