Re: RFR: 8256894: define test groups [v3]

2020-12-03 Thread Ivan Šipka
> Defined new test groups as defined in ticket. @fguallini Ivan Šipka has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since

Re: RFR: 8256894: define test groups [v2]

2020-12-02 Thread Igor Ignatyev
On Mon, 30 Nov 2020 21:10:13 GMT, Igor Ignatyev wrote: >> Ivan Šipka has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 8257516: removing trailing space > > @frkator, you will need to open a new JBS ticket for this change. > @iignatev as

Re: RFR: 8256894: define test groups [v2]

2020-12-02 Thread Ivan Šipka
On Mon, 30 Nov 2020 21:10:13 GMT, Igor Ignatyev wrote: >> Ivan Šipka has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 8257516: removing trailing space > > @frkator, you will need to open a new JBS ticket for this change. @iignatev as

Re: RFR: 8256894: define test groups [v2]

2020-12-01 Thread Ivan Šipka
> Defined new test groups as defined in ticket. @fguallini Ivan Šipka has updated the pull request incrementally with one additional commit since the last revision: 8257516: removing trailing space - Changes: - all: https://git.openjdk.java.net/jdk/pull/1416/files - new:

Re: RFR: 8256894: define test groups

2020-11-30 Thread Igor Ignatyev
On Tue, 24 Nov 2020 16:13:59 GMT, Ivan Šipka wrote: > Defined new test groups as defined in ticket. @fguallini @frkator, you will need to open a new JBS ticket for this change. test/jdk/TEST.groups line 326: > 324: :jdk_text \ > 325: :core_tools \ > 326: :jdk_other it would seem

Re: RFR: 8256894: define test groups

2020-11-30 Thread Igor Ignatyev
On Wed, 25 Nov 2020 20:31:50 GMT, Ivan Šipka wrote: >> test/jdk/TEST.groups line 327: >> >>> 325: :core_tools \ >>> 326: :jdk_other \ >>> 327: :jdk_core_manual >> >> Please don't add manual tests to jdk_core. > > Removed. aren't they already a part of `jdk_core` test group? e.g.

RFR: 8256894: define test groups

2020-11-25 Thread Ivan Šipka
Defined new test groups as defined in ticket. @fguallini - Commit messages: - 8256894: removing manual tests from corelibs tests - 8256894: define test groups Changes: https://git.openjdk.java.net/jdk/pull/1416/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk=1416=00

Re: RFR: 8256894: define test groups

2020-11-25 Thread Ivan Šipka
On Wed, 25 Nov 2020 11:19:27 GMT, Alan Bateman wrote: >> Defined new test groups as defined in ticket. @fguallini > > test/jdk/TEST.groups line 327: > >> 325: :core_tools \ >> 326: :jdk_other \ >> 327: :jdk_core_manual > > Please don't add manual tests to jdk_core. Removed.

Re: RFR: 8256894: define test groups

2020-11-25 Thread Alan Bateman
On Tue, 24 Nov 2020 16:13:59 GMT, Ivan Šipka wrote: > Defined new test groups as defined in ticket. @fguallini test/jdk/TEST.groups line 327: > 325: :core_tools \ > 326: :jdk_other \ > 327: :jdk_core_manual Please don't add manual tests to jdk_core. - PR: