Re: RFR: 8257924: Use full path when running external executable from jpackage

2020-12-09 Thread Andy Herrick
On Wed, 9 Dec 2020 08:05:17 GMT, Alexander Matveev wrote: > Changed all external executables to run via full path to avoid potential > issues. Marked as reviewed by herrick (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/1710

Re: RFR: 8257924: Use full path when running external executable from jpackage

2020-12-09 Thread Alexey Semenyuk
On Wed, 9 Dec 2020 08:05:17 GMT, Alexander Matveev wrote: > Changed all external executables to run via full path to avoid potential > issues. Marked as reviewed by asemenyuk (Committer). - PR: https://git.openjdk.java.net/jdk/pull/1710

Re: RFR: 8257924: Use full path when running external executable from jpackage

2020-12-09 Thread Alexander Matveev
On Wed, 9 Dec 2020 18:39:14 GMT, Alexey Semenyuk wrote: >> as long as your sure these are always in /usr/bin this is fine. >> If there is any chance of them being somewhere else instead we need a >> findTool type mechanism > > What if users would like to use not the default tools with jpackage?

Re: RFR: 8257924: Use full path when running external executable from jpackage

2020-12-09 Thread Alexey Semenyuk
On Wed, 9 Dec 2020 18:06:42 GMT, Andy Herrick wrote: >> Changed all external executables to run via full path to avoid potential >> issues. > > as long as your sure these are always in /usr/bin this is fine. > If there is any chance of them being somewhere else instead we need a > findTool type

Re: RFR: 8257924: Use full path when running external executable from jpackage

2020-12-09 Thread Andy Herrick
On Wed, 9 Dec 2020 08:05:17 GMT, Alexander Matveev wrote: > Changed all external executables to run via full path to avoid potential > issues. as long as your sure these are always in /usr/bin this is fine. If there is any chance of them being somewhere else instead we need a findTool type mec

RFR: 8257924: Use full path when running external executable from jpackage

2020-12-09 Thread Alexander Matveev
Changed all external executables to run via full path to avoid potential issues. - Commit messages: - 8257924: Use full path when running external executable from jpackage Changes: https://git.openjdk.java.net/jdk/pull/1710/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&p