Re: RFR: 8258117: jar tool sets the time stamp of module-info.class entries to the current time [v5]

2021-11-22 Thread Jaikiran Pai
On Mon, 22 Nov 2021 09:09:37 GMT, Jaikiran Pai wrote: >> test/jdk/tools/jar/modularJar/JarToolModuleDescriptorReproducibilityTest.java >> line 60: >> >>> 58: private static final String UPDATED_MODULE_VERSION = "1.2.4"; >>> 59: private static final String MAIN_CLASS =

Re: RFR: 8258117: jar tool sets the time stamp of module-info.class entries to the current time [v5]

2021-11-22 Thread Jaikiran Pai
On Mon, 22 Nov 2021 08:25:38 GMT, Alan Bateman wrote: >> Jaikiran Pai has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains seven additional >>

Re: RFR: 8258117: jar tool sets the time stamp of module-info.class entries to the current time [v5]

2021-11-22 Thread Alan Bateman
On Sat, 20 Nov 2021 01:58:54 GMT, Jaikiran Pai wrote: >> The commit here is a potential fix for the issue noted in >> https://bugs.openjdk.java.net/browse/JDK-8258117. >> >> The change here repurposes an existing internal interface `ModuleInfoEntry` >> to keep track of the last modified

Re: RFR: 8258117: jar tool sets the time stamp of module-info.class entries to the current time [v5]

2021-11-19 Thread Jaikiran Pai
> The commit here is a potential fix for the issue noted in > https://bugs.openjdk.java.net/browse/JDK-8258117. > > The change here repurposes an existing internal interface `ModuleInfoEntry` > to keep track of the last modified timestamp of a `module-info.class` > descriptor. > > This commit