On Mon, 11 Jan 2021 17:12:24 GMT, Andrey Turbanov
wrote:
>> Hi @turbanoff,
>> This PR is ready for integration - `JDK-8258657` has been resolved.
>> You can proceed with issuing `integrate` bot command. Then I will `sponsor`
>> it.
>> But before that, I would like to ask if you would like to ta
On Mon, 11 Jan 2021 23:29:53 GMT, Aleksei Efimov wrote:
>> @AlekseiEfimov `HttpClientImpl` is not in `java.base` module. So I think
>> it's better to not touch it under this PR.
>
> To double check that docs build will be stable after integration the
> following actions have been performed:
> -
On Mon, 11 Jan 2021 16:57:00 GMT, Aleksei Efimov wrote:
>> 8258422: Cleanup unnecessary null comparison before instanceof check in
>> java.base
>
> Hi @turbanoff,
> This PR is ready for integration - `JDK-8258657` has been resolved.
> You can proceed with issuing `integrate` bot command. Then I
On Sat, 5 Sep 2020 18:55:53 GMT, Andrey Turbanov
wrote:
> 8258422: Cleanup unnecessary null comparison before instanceof check in
> java.base
Hi @turbanoff,
This PR is ready for integration - `JDK-8258657` has been resolved.
You can proceed with issuing `integrate` bot command. Then I will `sp
On Fri, 8 Jan 2021 13:20:38 GMT, Aleksei Efimov wrote:
>> This issue is blocked by [8258657][1]. It should not be integrated until
>> after 8258657 has been resolved. The JIRA issues have been linked up to
>> reflect this.
>>
>> [1]: https://bugs.openjdk.java.net/browse/JDK-8258657
>
> [JDK-82
On Sat, 19 Dec 2020 10:29:23 GMT, Chris Hegarty wrote:
>> Thank you for checking `HttpURLConnection` and `Socket`.
>> The latest version looks good to me.
>
> This issue is blocked by [8258657][1]. It should not be integrated until
> after 8258657 has been resolved. The JIRA issues have been lin
On Thu, 17 Dec 2020 13:16:31 GMT, Aleksei Efimov wrote:
>> Andrey Turbanov has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8258422: Cleanup unnecessary null comparison before instanceof check in
>> java.base
>> take advantage of "flow
> 8258422: Cleanup unnecessary null comparison before instanceof check in
> java.base
Andrey Turbanov has updated the pull request incrementally with one additional
commit since the last revision:
8258422: Cleanup unnecessary null comparison before instanceof check in
java.base
rename 'oth
> 8258422: Cleanup unnecessary null comparison before instanceof check in
> java.base
Andrey Turbanov has updated the pull request incrementally with one additional
commit since the last revision:
8258422: Cleanup unnecessary null comparison before instanceof check in
java.base
rename 'oth
> On Dec 16, 2020, at 1:47 AM, Chris Hegarty wrote:
>
> On Wed, 16 Dec 2020 09:20:09 GMT, Andrey Turbanov
> wrote:
>
>>> 8258422: Cleanup unnecessary null comparison before instanceof check in
>>> java.base
>>
>> Andrey Turbanov has updated the pull request incrementally with one
>> addi
On Thu, 17 Dec 2020 14:01:14 GMT, Andrey Turbanov
wrote:
>> 8258422: Cleanup unnecessary null comparison before instanceof check in
>> java.base
>
> Andrey Turbanov has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8258422: Cleanup unnecess
> 8258422: Cleanup unnecessary null comparison before instanceof check in
> java.base
Andrey Turbanov has updated the pull request incrementally with one additional
commit since the last revision:
8258422: Cleanup unnecessary null comparison before instanceof check in
java.base
On Thu, 17 Dec 2020 13:32:06 GMT, Daniel Fuchs wrote:
>> Actually, I'm not sure if `oth` is better name for variable than `other1`.
>> I would say they have the same rank :)
>
> I believe Alan is suggesting to do:
>
> /**
> * Compares the equality of two Signal objects.
> *
>
On Thu, 17 Dec 2020 11:35:26 GMT, Andrey Turbanov
wrote:
>> src/java.base/share/classes/jdk/internal/misc/Signal.java line 102:
>>
>>> 100: */
>>> 101: public boolean equals(Object other) {
>>> 102: if (this == other) {
>>
>> It might be a bit cleaner to rename Object other to
On Wed, 16 Dec 2020 10:32:12 GMT, Andrey Turbanov
wrote:
>> 8258422: Cleanup unnecessary null comparison before instanceof check in
>> java.base
>
> Andrey Turbanov has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8258422: Cleanup unnecess
On Thu, 17 Dec 2020 10:29:50 GMT, Alan Bateman wrote:
>> Andrey Turbanov has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8258422: Cleanup unnecessary null comparison before instanceof check in
>> java.base
>> take advantage of "flow s
On Wed, 16 Dec 2020 10:32:12 GMT, Andrey Turbanov
wrote:
>> 8258422: Cleanup unnecessary null comparison before instanceof check in
>> java.base
>
> Andrey Turbanov has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8258422: Cleanup unnecess
On Wed, 16 Dec 2020 10:32:12 GMT, Andrey Turbanov
wrote:
>> 8258422: Cleanup unnecessary null comparison before instanceof check in
>> java.base
>
> Andrey Turbanov has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8258422: Cleanup unnecess
On Wed, 16 Dec 2020 18:27:35 GMT, Aleksei Efimov wrote:
>> Let's take advantage of "flow scoping" to eliminate some of these casts. A
>> few examples follow.
>
> Hi Andrey,
>
> Could you, please, also take a look at `java.net.Socket`:
> java/net/Socket.java:if (bindpoint != null && (!(b
On Wed, 16 Dec 2020 09:44:37 GMT, Chris Hegarty wrote:
>> Andrey Turbanov has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8258422: Cleanup unnecessary null comparison before instanceof check in
>> java.base
>> use instanceof pattern m
> 8258422: Cleanup unnecessary null comparison before instanceof check in
> java.base
Andrey Turbanov has updated the pull request incrementally with one additional
commit since the last revision:
8258422: Cleanup unnecessary null comparison before instanceof check in
java.base
take advant
On Wed, 16 Dec 2020 09:20:09 GMT, Andrey Turbanov
wrote:
>> 8258422: Cleanup unnecessary null comparison before instanceof check in
>> java.base
>
> Andrey Turbanov has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8258422: Cleanup unnecess
> 8258422: Cleanup unnecessary null comparison before instanceof check in
> java.base
Andrey Turbanov has updated the pull request incrementally with one additional
commit since the last revision:
8258422: Cleanup unnecessary null comparison before instanceof check in
java.base
use instanc
On Tue, 15 Dec 2020 19:52:31 GMT, Andrey Turbanov
wrote:
>> 8258422: Cleanup unnecessary null comparison before instanceof check in
>> java.base
>
> Andrey Turbanov has updated the pull request with a new target base due to a
> merge or a rebase. The pull request now contains two commits:
>
>
> 8258422: Cleanup unnecessary null comparison before instanceof check in
> java.base
Andrey Turbanov has updated the pull request with a new target base due to a
merge or a rebase. The incremental webrev excludes the unrelated changes
brought in by the merge/rebase. The pull request contains t
On Sat, 31 Oct 2020 19:37:10 GMT, Stuart Marks wrote:
>> I believe this changes is useful and still actual:
>> 1. improve code to make it easier to read.
>> 2. performance should be improved a bit too
>
> I’ll see if I can get somebody to take a look at this.
This seems like a reasonable change,
On Wed, 2 Dec 2020 20:15:02 GMT, Andrey Turbanov
wrote:
>> This seems like a reasonable change, which improves readability.
>>
>> My preference is to wait a little longer (hopefully no more than a couple of
>> weeks), until [JEP 394](https://openjdk.java.net/jeps/394) - "Pattern
>> Matching f
On Mon, 2 Nov 2020 09:15:31 GMT, Chris Hegarty wrote:
>> I’ll see if I can get somebody to take a look at this.
>
> This seems like a reasonable change, which improves readability.
>
> My preference is to wait a little longer (hopefully no more than a couple of
> weeks), until [JEP 394](https:/
On Sun, 4 Oct 2020 11:55:50 GMT, Andrey Turbanov
wrote:
>> 8258422: Cleanup unnecessary null comparison before instanceof check in
>> java.base
>
> I believe this changes is useful and still actual:
> 1. improve code to make it easier to read.
> 2. performance should be improved a bit too
I’ll
8258422: Cleanup unnecessary null comparison before instanceof check in
java.base
-
Commit messages:
- [PATCH] Cleanup unnecessary null comparison before instanceof check in
java.base
Changes: https://git.openjdk.java.net/jdk/pull/20/files
Webrev: https://webrevs.openjdk.java.net
On Sat, 5 Sep 2020 18:55:53 GMT, Andrey Turbanov
wrote:
> 8258422: Cleanup unnecessary null comparison before instanceof check in
> java.base
I believe this changes is useful and still actual:
1. improve code to make it easier to read.
2. performance should be improved a bit too
-
31 matches
Mail list logo
