Re: RFR: 8258444: Clean up specifications of java.io.Reader.read(char[], int, int) in subclass overrides [v2]

2021-02-25 Thread Brian Burkhalter
On Tue, 23 Feb 2021 18:00:33 GMT, Alan Bateman wrote: >> Brian Burkhalter has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8258444: Explcitly inherit IOOBE in {Filter,InputStream}Reader > > Marked as reviewed by alanb (Reviewer).

Re: RFR: 8258444: Clean up specifications of java.io.Reader.read(char[], int, int) in subclass overrides [v2]

2021-02-23 Thread Brian Burkhalter
On Tue, 23 Feb 2021 22:12:38 GMT, Daniel Fuchs wrote: >> Brian Burkhalter has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8258444: Explcitly inherit IOOBE in {Filter,InputStream}Reader > >

Re: RFR: 8258444: Clean up specifications of java.io.Reader.read(char[], int, int) in subclass overrides [v2]

2021-02-23 Thread Daniel Fuchs
On Tue, 23 Feb 2021 17:42:58 GMT, Brian Burkhalter wrote: >> 8258444: Clean up specifications of java.io.Reader.read(char[],int,int) in >> subclass overrides > > Brian Burkhalter has updated the pull request incrementally with one > additional commit since the last revision: > > 8258444:

Re: RFR: 8258444: Clean up specifications of java.io.Reader.read(char[], int, int) in subclass overrides [v2]

2021-02-23 Thread Roger Riggs
On Tue, 23 Feb 2021 17:42:58 GMT, Brian Burkhalter wrote: >> 8258444: Clean up specifications of java.io.Reader.read(char[],int,int) in >> subclass overrides > > Brian Burkhalter has updated the pull request incrementally with one > additional commit since the last revision: > > 8258444:

Re: RFR: 8258444: Clean up specifications of java.io.Reader.read(char[], int, int) in subclass overrides [v2]

2021-02-23 Thread Brian Burkhalter
On Tue, 23 Feb 2021 18:00:33 GMT, Alan Bateman wrote: >> Brian Burkhalter has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8258444: Explcitly inherit IOOBE in {Filter,InputStream}Reader > > Marked as reviewed by alanb (Reviewer). CSR

Re: RFR: 8258444: Clean up specifications of java.io.Reader.read(char[], int, int) in subclass overrides [v2]

2021-02-23 Thread Alan Bateman
On Tue, 23 Feb 2021 17:42:58 GMT, Brian Burkhalter wrote: >> 8258444: Clean up specifications of java.io.Reader.read(char[],int,int) in >> subclass overrides > > Brian Burkhalter has updated the pull request incrementally with one > additional commit since the last revision: > > 8258444:

Re: RFR: 8258444: Clean up specifications of java.io.Reader.read(char[], int, int) in subclass overrides [v2]

2021-02-23 Thread Brian Burkhalter
> 8258444: Clean up specifications of java.io.Reader.read(char[],int,int) in > subclass overrides Brian Burkhalter has updated the pull request incrementally with one additional commit since the last revision: 8258444: Explcitly inherit IOOBE in {Filter,InputStream}Reader -

Re: RFR: 8258444: Clean up specifications of java.io.Reader.read(char[], int, int) in subclass overrides

2021-02-23 Thread Brian Burkhalter
On Tue, 23 Feb 2021 16:23:10 GMT, Alan Bateman wrote: >> src/java.base/share/classes/java/io/InputStreamReader.java line 167: >> >>> 165: * {@inheritDoc} >>> 166: */ >>> 167: public int read(char[] cbuf, int off, int len) throws IOException { >> >> IOOBE is unchecked, are you

Re: RFR: 8258444: Clean up specifications of java.io.Reader.read(char[], int, int) in subclass overrides

2021-02-23 Thread Alan Bateman
On Tue, 23 Feb 2021 16:19:41 GMT, Brian Burkhalter wrote: >> src/java.base/share/classes/java/io/InputStreamReader.java line 167: >> >>> 165: * {@inheritDoc} >>> 166: */ >>> 167: public int read(char[] cbuf, int off, int len) throws IOException { >> >> IOOBE is unchecked, are you

Re: RFR: 8258444: Clean up specifications of java.io.Reader.read(char[], int, int) in subclass overrides

2021-02-23 Thread Brian Burkhalter
On Tue, 23 Feb 2021 08:48:16 GMT, Alan Bateman wrote: >> 8258444: Clean up specifications of java.io.Reader.read(char[],int,int) in >> subclass overrides > > src/java.base/share/classes/java/io/InputStreamReader.java line 167: > >> 165: * {@inheritDoc} >> 166: */ >> 167: public

Re: RFR: 8258444: Clean up specifications of java.io.Reader.read(char[], int, int) in subclass overrides

2021-02-23 Thread Alan Bateman
On Mon, 22 Feb 2021 23:27:19 GMT, Brian Burkhalter wrote: > 8258444: Clean up specifications of java.io.Reader.read(char[],int,int) in > subclass overrides Marked as reviewed by alanb (Reviewer). src/java.base/share/classes/java/io/InputStreamReader.java line 167: > 165: * {@inheritDoc}

Re: RFR: 8258444: Clean up specifications of java.io.Reader.read(char[], int, int) in subclass overrides

2021-02-22 Thread Brian Burkhalter
On Mon, 22 Feb 2021 23:27:19 GMT, Brian Burkhalter wrote: > 8258444: Clean up specifications of java.io.Reader.read(char[],int,int) in > subclass overrides This change proposes to use {@inheritDoc} to improve consistency of the specification of `Reader.read(char[],in,in)` in `Reader` and its

RFR: 8258444: Clean up specifications of java.io.Reader.read(char[], int, int) in subclass overrides

2021-02-22 Thread Brian Burkhalter
8258444: Clean up specifications of java.io.Reader.read(char[],int,int) in subclass overrides - Commit messages: - 8258444: Fix trailing whitesoace - 8258444: Clean up specifications of java.io.Reader.read(char[],int,int) in subclass overrides Changes: