On Tue, 2 Feb 2021 13:10:29 GMT, Claes Redestad wrote:
>> Martin Buchholz has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> fix imports
>
> Marked as reviewed by redestad (Reviewer).
@cl4es Your comment sent me back to jmh re-education ca
On Tue, 2 Feb 2021 03:07:08 GMT, Martin Buchholz wrote:
>> 8259074: regex benchmarks and tests
>
> Martin Buchholz has updated the pull request incrementally with one
> additional commit since the last revision:
>
> fix imports
Marked as reviewed by redestad (Reviewer).
-
PR: h
On Tue, 2 Feb 2021 02:58:30 GMT, Martin Buchholz wrote:
>>> A manual exploration of a new set of micros would naturally start with
>>> the default config, so if such a config runs forever, that would be poor
>>> ergonomics IMHO. I don't think such configurations should be checked in
>>> in an act
> 8259074: regex benchmarks and tests
Martin Buchholz has updated the pull request incrementally with one additional
commit since the last revision:
fix imports
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/1940/files
- new: https://git.openjdk.java.net/jdk/pull/194
On Tue, 2 Feb 2021 01:40:09 GMT, Martin Buchholz wrote:
>> @cl4es I agree pruning is a good idea. I settled on 3 data points with 16x
>> separations as good enough to clearly show the difference between O(1) O(N)
>> O(N^2) and O(2^N) (although O(2^N) would "run forever").
>>
>> (although ... p
> 8259074: regex benchmarks and tests
Martin Buchholz has updated the pull request incrementally with one additional
commit since the last revision:
add annotations for sensible defaults
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/1940/files
- new: https://git.ope
On Mon, 1 Feb 2021 20:52:12 GMT, Martin Buchholz wrote:
>> The assertion discussion aside, the micros look fine to me.
>>
>> With an eye towards reducing total run time I'd ask you to consider if all
>> parameter combinations are useful or if we can get the same value after some
>> pruning.
>
On Mon, 1 Feb 2021 00:23:56 GMT, Martin Buchholz wrote:
>> test/micro/org/openjdk/bench/java/util/regex/Trim.java line 119:
>>
>>> 117: assert ! lookBehind_find();
>>> 118: assert ! find_loop_two_matchers();
>>> 119: assert ! find_loop_usePattern();
>>
>> At a risk of mu
> 8259074: regex benchmarks and tests
Martin Buchholz has updated the pull request incrementally with two additional
commits since the last revision:
- refactor correctness checking as suggested by @shipilev
- prune @Param values as suggested by Claes
-
Changes:
- all: https://
On 2021-02-01 21:54, Martin Buchholz wrote:
On Mon, 1 Feb 2021 10:22:14 GMT, Claes Redestad wrote:
@amalloy - you are invited to comment on regex content
@cl4es @shipilev - you are invited to point out my jmh bad practices
The assertion discussion aside, the micros look fine to me.
With
On Mon, 1 Feb 2021 10:22:14 GMT, Claes Redestad wrote:
>> @amalloy - you are invited to comment on regex content
>> @cl4es @shipilev - you are invited to point out my jmh bad practices
>
> The assertion discussion aside, the micros look fine to me.
>
> With an eye towards reducing total run tim
On Mon, 1 Feb 2021 10:22:14 GMT, Claes Redestad wrote:
>> @amalloy - you are invited to comment on regex content
>> @cl4es @shipilev - you are invited to point out my jmh bad practices
>
> The assertion discussion aside, the micros look fine to me.
>
> With an eye towards reducing total run tim
On Sat, 30 Jan 2021 21:32:27 GMT, Martin Buchholz wrote:
>> 8259074: regex benchmarks and tests
>
> @amalloy - you are invited to comment on regex content
> @cl4es @shipilev - you are invited to point out my jmh bad practices
The assertion discussion aside, the micros look fine to me.
With an
On Sun, 31 Jan 2021 08:18:28 GMT, Aleksey Shipilev wrote:
>> Martin Buchholz has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> address comments from @amalloy; introduce technically correct use of
>> "numeral"
>
> test/micro/org/openjdk/be
On Sat, 30 Jan 2021 22:43:10 GMT, Martin Buchholz wrote:
>> 8259074: regex benchmarks and tests
>
> Martin Buchholz has updated the pull request incrementally with one
> additional commit since the last revision:
>
> address comments from @amalloy; introduce technically correct use of
> "num
> 8259074: regex benchmarks and tests
Martin Buchholz has updated the pull request incrementally with one additional
commit since the last revision:
address comments from @amalloy; introduce technically correct use of "numeral"
-
Changes:
- all: https://git.openjdk.java.net/jdk
On Tue, 5 Jan 2021 03:15:56 GMT, Martin Buchholz wrote:
> 8259074: regex benchmarks and tests
test/jdk/java/util/regex/TestCases.txt line 1248:
> 1246: false 1
> 1247:
> 1248: // Unary power of two (8), reluctant quantifier
I think the comment here is meant as "Giving a power of 2 as input to
On Tue, 5 Jan 2021 03:15:56 GMT, Martin Buchholz wrote:
> 8259074: regex benchmarks and tests
@amalloy - you are invited to comment on regex content
@cl4es @shipilev - you are invited to point out my jmh bad practices
-
PR: https://git.openjdk.java.net/jdk/pull/1940
8259074: regex benchmarks and tests
-
Commit messages:
- more benchmarks
- JDK-8259074
Changes: https://git.openjdk.java.net/jdk/pull/1940/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=1940&range=00
Issue: https://bugs.openjdk.java.net/browse/JDK-8259074
Stats: 4
19 matches
Mail list logo
