Re: RFR: 8260592: jpackage tests fail when Desktop is not supported [v2]

2021-01-29 Thread Alexey Semenyuk
On Fri, 29 Jan 2021 07:31:55 GMT, Aleksey Shipilev wrote: >> If you run x86 configuration (cross-compiled on x86_64), then many tests >> would fail with: >> >> $ CONF=linux-x86-server-fastdebug make images run-test TEST=tools/jpackage >> ... >> can not load libgnomevfs-2.so >> Exception in thre

Re: RFR: 8260592: jpackage tests fail when Desktop is not supported [v2]

2021-01-28 Thread Aleksey Shipilev
On Fri, 29 Jan 2021 01:13:30 GMT, Alexander Matveev wrote: >> Duplicated messages are not much help in understanding control flow. I'd >> change the new message or merge conditions. Whatever you prefer. > > It is fine with me to have two separate messages for display and desktop, but > it is b

Re: RFR: 8260592: jpackage tests fail when Desktop is not supported [v2]

2021-01-28 Thread Aleksey Shipilev
> If you run x86 configuration (cross-compiled on x86_64), then many tests > would fail with: > > $ CONF=linux-x86-server-fastdebug make images run-test TEST=tools/jpackage > ... > can not load libgnomevfs-2.so > Exception in thread "main" java.lang.ExceptionInInitializerError > Caused by: java.l

Re: RFR: 8260592: jpackage tests fail when Desktop is not supported

2021-01-28 Thread Alexander Matveev
On Thu, 28 Jan 2021 23:41:44 GMT, Alexey Semenyuk wrote: >> I would prefer to have separate messages for "headless" and "desktop >> capable". I can merge these, if you insist. > > Duplicated messages are not much help in understanding control flow. I'd > change the new message or merge conditio

Re: RFR: 8260592: jpackage tests fail when Desktop is not supported

2021-01-28 Thread Alexey Semenyuk
On Thu, 28 Jan 2021 22:05:17 GMT, Aleksey Shipilev wrote: >> test/jdk/tools/jpackage/apps/image/Hello.java line 166: >> >>> 164: } >>> 165: >>> 166: if (!Desktop.isDesktopSupported()) { >> >> Would it make more sense to replace >> `if (GraphicsEnvironment.isHeadless())` >> with

Re: RFR: 8260592: jpackage tests fail when Desktop is not supported

2021-01-28 Thread Aleksey Shipilev
On Thu, 28 Jan 2021 20:13:23 GMT, Alexey Semenyuk wrote: >> If you run x86 configuration (cross-compiled on x86_64), then many tests >> would fail with: >> >> $ CONF=linux-x86-server-fastdebug make images run-test TEST=tools/jpackage >> ... >> can not load libgnomevfs-2.so >> Exception in threa

Re: RFR: 8260592: jpackage tests fail when Desktop is not supported

2021-01-28 Thread Andy Herrick
On Thu, 28 Jan 2021 14:33:35 GMT, Aleksey Shipilev wrote: > If you run x86 configuration (cross-compiled on x86_64), then many tests > would fail with: > > $ CONF=linux-x86-server-fastdebug make images run-test TEST=tools/jpackage > ... > can not load libgnomevfs-2.so > Exception in thread "mai

Re: RFR: 8260592: jpackage tests fail when Desktop is not supported

2021-01-28 Thread Alexey Semenyuk
On Thu, 28 Jan 2021 14:33:35 GMT, Aleksey Shipilev wrote: > If you run x86 configuration (cross-compiled on x86_64), then many tests > would fail with: > > $ CONF=linux-x86-server-fastdebug make images run-test TEST=tools/jpackage > ... > can not load libgnomevfs-2.so > Exception in thread "mai

RFR: 8260592: jpackage tests fail when Desktop is not supported

2021-01-28 Thread Aleksey Shipilev
If you run x86 configuration (cross-compiled on x86_64), then many tests would fail with: $ CONF=linux-x86-server-fastdebug make images run-test TEST=tools/jpackage ... can not load libgnomevfs-2.so Exception in thread "main" java.lang.ExceptionInInitializerError Caused by: java.lang.UnsupportedO