On Tue, 2 Feb 2021 22:55:59 GMT, Lance Andersen wrote:
>> Claes Redestad has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Refactor out specific ZipException from checkedHash
>
> Thank you for the update Claes, the changes look fine
Thank
On Tue, 2 Feb 2021 10:40:01 GMT, Claes Redestad wrote:
>> - Merge checkEncoding into the byte[]-based normalizedHash. The latter is
>> only used from ZipFile.initCEN right after the checkEncoding today, so
>> verifying this is equivalent is straightforward.
>> - Factor out the logic to calculat
On Sun, 31 Jan 2021 18:05:30 GMT, Lance Andersen wrote:
>> Claes Redestad has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Clarify comments, put normal path branch first in UTF8 checkedHash
>
> Hi Claes
>
> I gone through your changes a
> - Merge checkEncoding into the byte[]-based normalizedHash. The latter is
> only used from ZipFile.initCEN right after the checkEncoding today, so
> verifying this is equivalent is straightforward.
> - Factor out the logic to calculate hash, check encoding etc into the
> addEntry method to all
On Sat, 30 Jan 2021 18:30:59 GMT, Claes Redestad wrote:
>> - Merge checkEncoding into the byte[]-based normalizedHash. The latter is
>> only used from ZipFile.initCEN right after the checkEncoding today, so
>> verifying this is equivalent is straightforward.
>> - Factor out the logic to calcula
> - Merge checkEncoding into the byte[]-based normalizedHash. The latter is
> only used from ZipFile.initCEN right after the checkEncoding today, so
> verifying this is equivalent is straightforward.
> - Factor out the logic to calculate hash, check encoding etc into the
> addEntry method to all
On Fri, 29 Jan 2021 18:43:40 GMT, Lance Andersen wrote:
>> Claes Redestad has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Refactor to do most entry validation in one place, out of line from
>> initCEN.
>
> src/java.base/share/classes/ja
> - Merge checkEncoding into the byte[]-based normalizedHash. The latter is
> only used from ZipFile.initCEN right after the checkEncoding today, so
> verifying this is equivalent is straightforward.
> - Factor out the logic to calculate hash, check encoding etc into the
> addEntry method to all
On Fri, 29 Jan 2021 00:54:46 GMT, Claes Redestad wrote:
> - Merge checkEncoding into the byte[]-based normalizedHash. The latter is
> only used from ZipFile.initCEN right after the checkEncoding today, so
> verifying this is equivalent is straightforward.
> - Factor out the logic to calculate h
On Fri, 29 Jan 2021 00:54:46 GMT, Claes Redestad wrote:
> - Merge checkEncoding into the byte[]-based normalizedHash. The latter is
> only used from ZipFile.initCEN right after the checkEncoding today, so
> verifying this is equivalent is straightforward.
> - Factor out the logic to calculate h
- Merge checkEncoding into the byte[]-based normalizedHash. The latter is only
used from ZipFile.initCEN right after the checkEncoding today, so verifying
this is equivalent is straightforward.
- Factor out the logic to calculate hash, check encoding etc into the addEntry
method to allow JITs to
11 matches
Mail list logo
