Re: RFR: 8260617: Merge ZipFile encoding check with the initial hash calculation [v3]

2021-02-02 Thread Claes Redestad
On Sun, 31 Jan 2021 18:05:30 GMT, Lance Andersen wrote: >> Claes Redestad has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Clarify comments, put normal path branch first in UTF8 checkedHash > > Hi Claes > > I gone through your changes a

Re: RFR: 8260617: Merge ZipFile encoding check with the initial hash calculation [v3]

2021-01-31 Thread Lance Andersen
On Sat, 30 Jan 2021 18:30:59 GMT, Claes Redestad wrote: >> - Merge checkEncoding into the byte[]-based normalizedHash. The latter is >> only used from ZipFile.initCEN right after the checkEncoding today, so >> verifying this is equivalent is straightforward. >> - Factor out the logic to calcula

Re: RFR: 8260617: Merge ZipFile encoding check with the initial hash calculation [v3]

2021-01-30 Thread Claes Redestad
> - Merge checkEncoding into the byte[]-based normalizedHash. The latter is > only used from ZipFile.initCEN right after the checkEncoding today, so > verifying this is equivalent is straightforward. > - Factor out the logic to calculate hash, check encoding etc into the > addEntry method to all