Re: RFR: 8264019: Use the blessed modifier order in java.xml

2021-03-23 Thread Alex Blewitt
On Tue, 23 Mar 2021 17:19:10 GMT, Joe Wang wrote: >> The JDK's copy of the xalan and xerces code has diverged significantly from >> upstream so maybe this change is okay, Joe Wang can say. > > Hi Alex, thanks for looking into this. As Alan mentioned, these code came > from Apache, while we've

Re: RFR: 8264019: Use the blessed modifier order in java.xml

2021-03-23 Thread Joe Wang
On Tue, 23 Mar 2021 07:24:47 GMT, Alan Bateman wrote: >> Sure, here it is: https://bugs.openjdk.java.net/browse/JDK-8264019 > > The JDK's copy of the xalan and xerces code has diverged significantly from > upstream so maybe this change is okay, Joe Wang can say. Hi Alex, thanks for looking int

Re: RFR: 8264019: Use the blessed modifier order in java.xml

2021-03-23 Thread Alan Bateman
On Tue, 23 Mar 2021 06:53:03 GMT, Aleksey Shipilev wrote: >> @shipilev would you mind creating a bug for me please? > > Sure, here it is: https://bugs.openjdk.java.net/browse/JDK-8264019 The JDK's copy of the xalan and xerces code has diverged significantly from upstream so maybe this change is

Re: RFR: 8264019: Use the blessed modifier order in java.xml

2021-03-23 Thread Alex Blewitt
On Fri, 19 Mar 2021 23:40:00 GMT, Alex Blewitt wrote: >> As a subtask of JDK-8263854 this cleans up the `java.xml` module to used the >> blessed modifier order. > > Would someone mind creating a bug for me under the parent bug JDK-8263854? @shipilev would you mind creating a bug for me please?

Re: RFR: 8264019: Use the blessed modifier order in java.xml

2021-03-23 Thread Aleksey Shipilev
On Mon, 22 Mar 2021 20:55:55 GMT, Alex Blewitt wrote: >> Would someone mind creating a bug for me under the parent bug JDK-8263854? > > @shipilev would you mind creating a bug for me please? Sure, here it is: https://bugs.openjdk.java.net/browse/JDK-8264019 - PR: https://git.openj

Re: RFR: 8264019: Use the blessed modifier order in java.xml

2021-03-23 Thread Alex Blewitt
On Fri, 19 Mar 2021 16:17:40 GMT, Alex Blewitt wrote: > As a subtask of JDK-8263854 this cleans up the `java.xml` module to used the > blessed modifier order. Would someone mind creating a bug for me under the parent bug JDK-8263854? - PR: https://git.openjdk.java.net/jdk/pull/30

RFR: 8264019: Use the blessed modifier order in java.xml

2021-03-23 Thread Alex Blewitt
As a subtask of JDK-8263854 this cleans up the `java.xml` module to used the blessed modifier order. - Commit messages: - Reordered final static to static final - Use the blessed modifier order in java.xml Changes: https://git.openjdk.java.net/jdk/pull/3091/files Webrev: https://