On Wed, 24 Mar 2021 23:17:46 GMT, Joe Darcy wrote:
> 8264148: Update spec for exceptions retrofitted for exception chaining
Joe,
The Serviceability part looks good.
Thanks,
Serguei
-
PR: https://git.openjdk.java.net/jdk/pull/3182
On Wed, 24 Mar 2021 23:17:46 GMT, Joe Darcy wrote:
> 8264148: Update spec for exceptions retrofitted for exception chaining
Marked as reviewed by smarks (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/3182
On 3/30/2021 6:29 AM, Roger Riggs wrote:
On Wed, 24 Mar 2021 23:17:46 GMT, Joe Darcy wrote:
8264148: Update spec for exceptions retrofitted for exception chaining
I agree that the public field in WriteAbortedException could be remediated.
But it is also mostly harmless.
src/jdk.hotspot.age
On 3/30/2021 6:43 AM, jmehrens wrote:
On Wed, 24 Mar 2021 23:17:46 GMT, Joe Darcy wrote:
8264148: Update spec for exceptions retrofitted for exception chaining
src/java.base/share/classes/java/io/WriteAbortedException.java line 86:
84: @Override
85: public Throwable getCause() {
8
On Wed, 24 Mar 2021 23:17:46 GMT, Joe Darcy wrote:
> 8264148: Update spec for exceptions retrofitted for exception chaining
src/java.base/share/classes/java/io/WriteAbortedException.java line 86:
> 84: @Override
> 85: public Throwable getCause() {
> 86: return detail;
Use Suppr
On Wed, 24 Mar 2021 23:17:46 GMT, Joe Darcy wrote:
> 8264148: Update spec for exceptions retrofitted for exception chaining
I agree that the public field in WriteAbortedException could be remediated.
But it is also mostly harmless.
src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/runtime/VMO
On Thu, 25 Mar 2021 18:52:54 GMT, Stuart Marks wrote:
> One special case is the **public field** in `WriteAbortedException`. This is
> really bad and something ought to be done about this, including deprecation,
> and maybe more. This implies that the exception is mutable, right? Hrrmph.
> Isn
On Thu, 25 Mar 2021 18:52:54 GMT, Stuart Marks wrote:
>> 8264148: Update spec for exceptions retrofitted for exception chaining
>
> The removal of the obsolescent "As of release 1.4, this exception has been
> retrofitted..." is good. Changing the calls from the other exception-getting
> methods
On Wed, 24 Mar 2021 23:17:46 GMT, Joe Darcy wrote:
> 8264148: Update spec for exceptions retrofitted for exception chaining
The removal of the obsolescent "As of release 1.4, this exception has been
retrofitted..." is good. Changing the calls from the other exception-getting
methods to `getCau
8264148: Update spec for exceptions retrofitted for exception chaining
-
Commit messages:
- Respond to review feedback.
- Respond to review feedback.
- Merge branch 'master' into 8264148
- Merge branch 'master' into 8264148
- 8264148: Update spec for exceptions retrofitted for ex
10 matches
Mail list logo
