Re: RFR: 8264397: Use the blessed modifier order in jdk.incubator.foreign

2021-03-31 Thread Alex Blewitt
On Tue, 30 Mar 2021 21:26:34 GMT, Alex Blewitt wrote: >> Hi @alblue, thanks for the contribution. We will make sure to integrate this >> at some point, but I don't think now is the right moment to do this kind of >> stylistic changes to the API/implementation. If you want to integrate the >>

Re: RFR: 8264397: Use the blessed modifier order in jdk.incubator.foreign

2021-03-30 Thread Alex Blewitt
On Tue, 30 Mar 2021 11:48:36 GMT, Maurizio Cimadamore wrote: >> Happy to submit a fix elsewhere if that's the right thing to do? > > Hi @alblue, thanks for the contribution. We will make sure to integrate this > at some point, but I don't think now is the right moment to do this kind of > styl

Re: RFR: 8264397: Use the blessed modifier order in jdk.incubator.foreign

2021-03-30 Thread Maurizio Cimadamore
On Tue, 30 Mar 2021 08:14:58 GMT, Alex Blewitt wrote: >> This one should probably be fixed in the upstream repo over at >> https://github.com/openjdk/panama-foreign (I believe). /ping @JornVernee >> @mcimadamore > > Happy to submit a fix elsewhere if that's the right thing to do? Hi @alblue,

Re: RFR: 8264397: Use the blessed modifier order in jdk.incubator.foreign

2021-03-30 Thread Alex Blewitt
On Mon, 29 Mar 2021 23:54:19 GMT, Claes Redestad wrote: >> 8264397: Use the blessed modifier order in jdk.incubator.foreign > > This one should probably be fixed in the upstream repo over at > https://github.com/openjdk/panama-foreign (I believe). /ping @JornVernee > @mcimadamore Happy to subm

Re: RFR: 8264397: Use the blessed modifier order in jdk.incubator.foreign

2021-03-29 Thread Claes Redestad
On Mon, 29 Mar 2021 21:09:56 GMT, Alex Blewitt wrote: > 8264397: Use the blessed modifier order in jdk.incubator.foreign This one should probably be fixed in the upstream repo over at https://github.com/openjdk/panama-foreign (I believe). /ping @JornVernee @mcimadamore - PR: htt

RFR: 8264397: Use the blessed modifier order in jdk.incubator.foreign

2021-03-29 Thread Alex Blewitt
8264397: Use the blessed modifier order in jdk.incubator.foreign - Commit messages: - 8264397: Use the blessed modifier order in jdk.incubator.foreign Changes: https://git.openjdk.java.net/jdk/pull/3253/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=3253&range=00 Iss