Re: RFR: 8264827: Large mapped buffer/segment crash the VM when calling isLoaded [v2]

2021-04-12 Thread Maurizio Cimadamore
On Mon, 12 Apr 2021 08:31:51 GMT, Chris Hegarty wrote: >> Avoid overflow when calculating the number of pages for large mapped segment >> sizes. > > Chris Hegarty has updated the pull request incrementally with one additional > commit since the last revision: > > Skip testing on 32-bit syste

Re: RFR: 8264827: Large mapped buffer/segment crash the VM when calling isLoaded [v2]

2021-04-12 Thread Chris Hegarty
> Avoid overflow when calculating the number of pages for large mapped segment > sizes. Chris Hegarty has updated the pull request incrementally with one additional commit since the last revision: Skip testing on 32-bit systems - Changes: - all: https://git.openjdk.java.net/jd

Re: RFR: 8264827: Large mapped buffer/segment crash the VM when calling isLoaded

2021-04-09 Thread Alan Bateman
On Wed, 7 Apr 2021 15:45:30 GMT, Chris Hegarty wrote: > Avoid overflow when calculating the number of pages for large mapped segment > sizes. Looks okay to me. - Marked as reviewed by alanb (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/3378

Re: RFR: 8264827: Large mapped buffer/segment crash the VM when calling isLoaded

2021-04-09 Thread Chris Hegarty
On Wed, 7 Apr 2021 15:45:30 GMT, Chris Hegarty wrote: > Avoid overflow when calculating the number of pages for large mapped segment > sizes. Note for reviewers on the test. A 3GB file is sufficient to demonstrate the issue in the old code, as follows (with a 4K page size, since the narrowing

RFR: 8264827: Large mapped buffer/segment crash the VM when calling isLoaded

2021-04-09 Thread Chris Hegarty
Avoid overflow when calculating the number of pages for large mapped segment sizes. - Commit messages: - Test update - Initial changes Changes: https://git.openjdk.java.net/jdk/pull/3378/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=3378&range=00 Issue: https://bu