Re: RFR: 8265237: String.join and StringJoiner can be improved further [v3]

2021-04-19 Thread Roger Riggs
On Sun, 18 Apr 2021 19:55:20 GMT, Peter Levart wrote: >> While JDK-8148937 improved StringJoiner class by replacing internal use of >> getChars that copies out characters from String elements into a char[] array >> with StringBuilder which is somehow more optimal, the improvement was >> margin

Re: RFR: 8265237: String.join and StringJoiner can be improved further [v3]

2021-04-19 Thread Peter Levart
On Mon, 19 Apr 2021 10:44:04 GMT, Claes Redestad wrote: >> Peter Levart has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fix overflow checking logic, add test for it, avoid branch in loop, add >> 1-char strings to JHM test > > test/micro

Re: RFR: 8265237: String.join and StringJoiner can be improved further [v3]

2021-04-19 Thread Claes Redestad
On Sun, 18 Apr 2021 19:55:20 GMT, Peter Levart wrote: >> While JDK-8148937 improved StringJoiner class by replacing internal use of >> getChars that copies out characters from String elements into a char[] array >> with StringBuilder which is somehow more optimal, the improvement was >> margin

Re: RFR: 8265237: String.join and StringJoiner can be improved further [v3]

2021-04-18 Thread Peter Levart
On Sun, 18 Apr 2021 19:55:20 GMT, Peter Levart wrote: >> While JDK-8148937 improved StringJoiner class by replacing internal use of >> getChars that copies out characters from String elements into a char[] array >> with StringBuilder which is somehow more optimal, the improvement was >> margin

Re: RFR: 8265237: String.join and StringJoiner can be improved further [v3]

2021-04-18 Thread Peter Levart
> While JDK-8148937 improved StringJoiner class by replacing internal use of > getChars that copies out characters from String elements into a char[] array > with StringBuilder which is somehow more optimal, the improvement was > marginal in speed (0% ... 10%) and mainly for smaller strings, whi