Re: RFR: 8266310: deadlock while loading the JNI code [v5]

2021-05-31 Thread Peter Levart
On Thu, 27 May 2021 14:28:09 GMT, Aleksei Voitylov wrote: >> src/java.base/share/classes/jdk/internal/loader/NativeLibraries.java line >> 481: >> >>> 479: throw new Error("Maximum lock count exceeded"); >>> 480: } >>> 481: >> >> Hi Aleksei, >> I know in practice this

Re: RFR: 8266310: deadlock while loading the JNI code [v5]

2021-05-27 Thread Aleksei Voitylov
On Fri, 21 May 2021 15:49:09 GMT, Aleksei Voitylov wrote: >> Please review this PR which fixes the deadlock in ClassLoader between the >> two lock objects - a lock object associated with the class being loaded, and >> the ClassLoader.loadedLibraryNames hash map, locked during the native >>

Re: RFR: 8266310: deadlock while loading the JNI code [v5]

2021-05-27 Thread Aleksei Voitylov
On Wed, 26 May 2021 07:30:10 GMT, Peter Levart wrote: >> Aleksei Voitylov has updated the pull request incrementally with one >> additional commit since the last revision: >> >> fix whitespace > > src/java.base/share/classes/jdk/internal/loader/NativeLibraries.java line 481: > >> 479:

Re: RFR: 8266310: deadlock while loading the JNI code [v5]

2021-05-27 Thread Aleksei Voitylov
On Wed, 26 May 2021 02:36:34 GMT, David Holmes wrote: >> Aleksei Voitylov has updated the pull request incrementally with one >> additional commit since the last revision: >> >> fix whitespace > > src/java.base/share/classes/jdk/internal/loader/NativeLibraries.java line 497: > >> 495: >>

Re: RFR: 8266310: deadlock while loading the JNI code [v5]

2021-05-26 Thread Mandy Chung
On Fri, 21 May 2021 15:49:09 GMT, Aleksei Voitylov wrote: >> Please review this PR which fixes the deadlock in ClassLoader between the >> two lock objects - a lock object associated with the class being loaded, and >> the ClassLoader.loadedLibraryNames hash map, locked during the native >>

Re: RFR: 8266310: deadlock while loading the JNI code [v5]

2021-05-26 Thread Peter Levart
On Fri, 21 May 2021 15:49:09 GMT, Aleksei Voitylov wrote: >> Please review this PR which fixes the deadlock in ClassLoader between the >> two lock objects - a lock object associated with the class being loaded, and >> the ClassLoader.loadedLibraryNames hash map, locked during the native >>

Re: RFR: 8266310: deadlock while loading the JNI code [v5]

2021-05-25 Thread David Holmes
On Fri, 21 May 2021 15:49:09 GMT, Aleksei Voitylov wrote: >> Please review this PR which fixes the deadlock in ClassLoader between the >> two lock objects - a lock object associated with the class being loaded, and >> the ClassLoader.loadedLibraryNames hash map, locked during the native >>

Re: RFR: 8266310: deadlock while loading the JNI code [v5]

2021-05-25 Thread Aleksei Voitylov
On 25/05/2021 04:44, David Holmes wrote: > On 25/05/2021 7:53 am, Aleksei Voitylov wrote: >> On Mon, 24 May 2021 06:24:15 GMT, David Holmes >> wrote: >> Aleksei Voitylov has updated the pull request incrementally with one additional commit since the last revision:    fix

Re: RFR: 8266310: deadlock while loading the JNI code [v5]

2021-05-24 Thread David Holmes
On 25/05/2021 7:53 am, Aleksei Voitylov wrote: On Mon, 24 May 2021 06:24:15 GMT, David Holmes wrote: Aleksei Voitylov has updated the pull request incrementally with one additional commit since the last revision: fix whitespace

Re: RFR: 8266310: deadlock while loading the JNI code [v5]

2021-05-24 Thread Aleksei Voitylov
On Mon, 24 May 2021 06:24:15 GMT, David Holmes wrote: >> Aleksei Voitylov has updated the pull request incrementally with one >> additional commit since the last revision: >> >> fix whitespace > > src/java.base/share/classes/jdk/internal/loader/NativeLibraries.java line 511: > >> 509:

Re: RFR: 8266310: deadlock while loading the JNI code [v5]

2021-05-24 Thread David Holmes
On Fri, 21 May 2021 15:49:09 GMT, Aleksei Voitylov wrote: >> Please review this PR which fixes the deadlock in ClassLoader between the >> two lock objects - a lock object associated with the class being loaded, and >> the ClassLoader.loadedLibraryNames hash map, locked during the native >>

Re: RFR: 8266310: deadlock while loading the JNI code [v5]

2021-05-21 Thread Aleksei Voitylov
On Fri, 21 May 2021 15:49:09 GMT, Aleksei Voitylov wrote: >> Please review this PR which fixes the deadlock in ClassLoader between the >> two lock objects - a lock object associated with the class being loaded, and >> the ClassLoader.loadedLibraryNames hash map, locked during the native >>

Re: RFR: 8266310: deadlock while loading the JNI code [v5]

2021-05-21 Thread Aleksei Voitylov
> Please review this PR which fixes the deadlock in ClassLoader between the two > lock objects - a lock object associated with the class being loaded, and the > ClassLoader.loadedLibraryNames hash map, locked during the native library > load operation. > > Problem being fixed: > > The initial