Re: RFR: 8266456: Replace direct TKit.run() calls with jdk.jpackage.test.Annotations.Test annotation [v2]

2021-05-10 Thread Alexander Matveev
On Sat, 8 May 2021 01:44:46 GMT, Alexander Matveev wrote: >> - Replaced direct TKit.run() calls with Test annotation. >> - Increased timeout for SigningPackageTest from default to 360 due to >> timeout. This is regression from JDK-8248904 due to changes done in signing >> and

Re: RFR: 8266456: Replace direct TKit.run() calls with jdk.jpackage.test.Annotations.Test annotation [v2]

2021-05-10 Thread Alexey Semenyuk
On Fri, 7 May 2021 23:07:02 GMT, Alexander Matveev wrote: >> test/jdk/tools/jpackage/helpers/jdk/jpackage/test/Functional.java line 161: >> >>> 159: } >>> 160: >>> 161: if >>> (throwable.getClass().getName().equals("jtreg.SkippedException")) { >> >> Would it make sense to

Re: RFR: 8266456: Replace direct TKit.run() calls with jdk.jpackage.test.Annotations.Test annotation [v2]

2021-05-10 Thread Alexey Semenyuk
On Sat, 8 May 2021 01:44:46 GMT, Alexander Matveev wrote: >> - Replaced direct TKit.run() calls with Test annotation. >> - Increased timeout for SigningPackageTest from default to 360 due to >> timeout. This is regression from JDK-8248904 due to changes done in signing >> and

Re: RFR: 8266456: Replace direct TKit.run() calls with jdk.jpackage.test.Annotations.Test annotation [v2]

2021-05-07 Thread Alexander Matveev
> - Replaced direct TKit.run() calls with Test annotation. > - Increased timeout for SigningPackageTest from default to 360 due to > timeout. This is regression from JDK-8248904 due to changes done in signing > and --remove-signature adds additional time since it is run per file. > - Fixed