Re: RFR: 8266936: Add a finalization JFR event [v12]

2021-10-18 Thread Markus Grönlund
On Fri, 24 Sep 2021 22:31:18 GMT, Mandy Chung wrote: >> Markus Grönlund has updated the pull request incrementally with one >> additional commit since the last revision: >> >> no precompiled headers and mtServiceability nmt classification > > Hi Markus, > > It's a little surprised to see

Re: RFR: 8266936: Add a finalization JFR event [v12]

2021-09-25 Thread Markus Grönlund
On Fri, 24 Sep 2021 22:31:18 GMT, Mandy Chung wrote: > > > Hi Markus, > > It's a little surprised to see Finalizer.c to depend JMM interface which is > used by `java.management` and `jdk.management` modules only. It's more > appropriate for it to be a JVM_* entry point for Finalizer to

Re: RFR: 8266936: Add a finalization JFR event [v12]

2021-09-24 Thread Mandy Chung
On Fri, 24 Sep 2021 09:27:02 GMT, Markus Grönlund wrote: >> Greetings, >> >> Object.finalize() was deprecated in JDK9. There is an ongoing effort to >> replace and mitigate Object.finalize() uses in the JDK libraries; please see >> https://bugs.openjdk.java.net/browse/JDK-8253568 for more

Re: RFR: 8266936: Add a finalization JFR event [v12]

2021-09-24 Thread Markus Grönlund
> Greetings, > > Object.finalize() was deprecated in JDK9. There is an ongoing effort to > replace and mitigate Object.finalize() uses in the JDK libraries; please see > https://bugs.openjdk.java.net/browse/JDK-8253568 for more information. > > We also like to assist users in replacing and