> Please review this simple PR along with the associated CSR. The PR is
> basically adding a line the the specification of method
> `java.lang.runtime.ObjectMethods::bootstrap` stating under what conditions a
> NPE will be thrown.
>
> TIA
>
> link to the [CSR](https://bugs.openjdk.java.net/bro
On Mon, 30 Aug 2021 01:45:49 GMT, Mandy Chung wrote:
>> Vicente Romero has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> clarifying that the names parameter is ignored in some cases
>
> src/java.base/share/classes/java/lang/runtime/ObjectM
On Thu, 26 Aug 2021 02:36:47 GMT, Vicente Romero wrote:
>> Please review this simple PR along with the associated CSR. The PR is
>> basically adding a line the the specification of method
>> `java.lang.runtime.ObjectMethods::bootstrap` stating under what conditions a
>> NPE will be thrown.
>>
> Please review this simple PR along with the associated CSR. The PR is
> basically adding a line the the specification of method
> `java.lang.runtime.ObjectMethods::bootstrap` stating under what conditions a
> NPE will be thrown.
>
> TIA
>
> link to the [CSR](https://bugs.openjdk.java.net/bro
On 8/25/21 4:45 PM, Mandy Chung wrote:
On 8/25/21 12:08 PM, Vicente Romero wrote:
On Wed, 25 Aug 2021 02:17:12 GMT, Mandy Chung wrote:
Hi Mandy, I have changed the implementation of the method to explicitly require
all arguments but lookup to be non-null as suggested by Brian. I have al
On 8/25/21 12:08 PM, Vicente Romero wrote:
On Wed, 25 Aug 2021 02:17:12 GMT, Mandy Chung wrote:
Hi Mandy, I have changed the implementation of the method to explicitly require
all arguments but lookup to be non-null as suggested by Brian. I have also
covered, I think, all the missing test
On Wed, 25 Aug 2021 02:17:12 GMT, Mandy Chung wrote:
>> Hi Mandy, I have changed the implementation of the method to explicitly
>> require all arguments but lookup to be non-null as suggested by Brian. I
>> have also covered, I think, all the missing test cases in test
>> `ObjectMethodsTest`,
On Tue, 24 Aug 2021 03:03:37 GMT, Vicente Romero wrote:
>> src/java.base/share/classes/java/lang/runtime/ObjectMethods.java line 327:
>>
>>> 325: * @throws IllegalArgumentException if the bootstrap arguments are
>>> invalid
>>> 326: * or inconsistent
>
On Tue, 24 Aug 2021 03:03:48 GMT, Vicente Romero wrote:
>> Please review this simple PR along with the associated CSR. The PR is
>> basically adding a line the the specification of method
>> `java.lang.runtime.ObjectMethods::bootstrap` stating under what conditions a
>> NPE will be thrown.
>>
On Mon, 23 Aug 2021 23:13:58 GMT, Mandy Chung wrote:
>> Vicente Romero has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> addressing review comments
>
> src/java.base/share/classes/java/lang/runtime/ObjectMethods.java line 327:
>
>> 325:
> Please review this simple PR along with the associated CSR. The PR is
> basically adding a line the the specification of method
> `java.lang.runtime.ObjectMethods::bootstrap` stating under what conditions a
> NPE will be thrown.
>
> TIA
>
> link to the [CSR](https://bugs.openjdk.java.net/bro
On 8/23/21 4:07 PM, Brian Goetz wrote:
Actually, it will not NPE if `names` is null and you have selected
equals/hashCode as the name. Might be better to do requiresNonNull()
up front for all the arguments, just to make such analysis simpler:
requireNonNull(methodName);
requireNonNull(type
On Mon, 23 Aug 2021 18:08:02 GMT, Vicente Romero wrote:
> Please review this simple PR along with the associated CSR. The PR is
> basically adding a line the the specification of method
> `java.lang.runtime.ObjectMethods::bootstrap` stating under what conditions a
> NPE will be thrown.
>
> TI
Actually, it will not NPE if `names` is null and you have selected
equals/hashCode as the name. Might be better to do requiresNonNull() up
front for all the arguments, just to make such analysis simpler:
requireNonNull(methodName);
requireNonNull(type);
requireNonNull(recordClass);
requireNonN
+1
On 8/23/2021 2:22 PM, Vicente Romero wrote:
Please review this simple PR along with the associated CSR. The PR is basically
adding a line the the specification of method
`java.lang.runtime.ObjectMethods::bootstrap` stating under what conditions a
NPE will be thrown.
TIA
link to the [CSR]
Please review this simple PR along with the associated CSR. The PR is basically
adding a line the the specification of method
`java.lang.runtime.ObjectMethods::bootstrap` stating under what conditions a
NPE will be thrown.
TIA
link to the [CSR](https://bugs.openjdk.java.net/browse/JDK-8272852)
16 matches
Mail list logo
