Re: RFR: 8273242: (test) Refactor to use TestNG for RuntimeTests ExecCommand tests [v2]

2021-09-08 Thread Naoto Sato
On Wed, 8 Sep 2021 19:31:46 GMT, Roger Riggs wrote: >> The ExecCommand test of Runtime.exec is difficult to maintain; the parallel >> arrays are hard to keep in sync. >> This cleanup converts to use TestNG DataProviders and other improvements. > > Roger Riggs has updated the pull request with a

Re: RFR: 8273242: (test) Refactor to use TestNG for RuntimeTests ExecCommand tests [v2]

2021-09-08 Thread Lance Andersen
On Wed, 8 Sep 2021 19:31:46 GMT, Roger Riggs wrote: >> The ExecCommand test of Runtime.exec is difficult to maintain; the parallel >> arrays are hard to keep in sync. >> This cleanup converts to use TestNG DataProviders and other improvements. > > Roger Riggs has updated the pull request with a

Re: RFR: 8273242: (test) Refactor to use TestNG for RuntimeTests ExecCommand tests [v2]

2021-09-08 Thread Roger Riggs
On Tue, 7 Sep 2021 22:01:54 GMT, Lance Andersen wrote: >> Roger Riggs has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains three additional >> commit

Re: RFR: 8273242: (test) Refactor to use TestNG for RuntimeTests ExecCommand tests [v2]

2021-09-08 Thread Roger Riggs
> The ExecCommand test of Runtime.exec is difficult to maintain; the parallel > arrays are hard to keep in sync. > This cleanup converts to use TestNG DataProviders and other improvements. Roger Riggs has updated the pull request with a new target base due to a merge or a rebase. The incremental

Re: RFR: 8273242: (test) Refactor to use TestNG for RuntimeTests ExecCommand tests

2021-09-07 Thread Lance Andersen
On Wed, 1 Sep 2021 16:37:24 GMT, Roger Riggs wrote: > The ExecCommand test of Runtime.exec is difficult to maintain; the parallel > arrays are hard to keep in sync. > This cleanup converts to use TestNG DataProviders and other improvements. Looks good Roger. A couple trivial questions/suggesti

Re: RFR: 8273242: (test) Refactor to use TestNG for RuntimeTests ExecCommand tests

2021-09-07 Thread Naoto Sato
On Wed, 1 Sep 2021 16:37:24 GMT, Roger Riggs wrote: > The ExecCommand test of Runtime.exec is difficult to maintain; the parallel > arrays are hard to keep in sync. > This cleanup converts to use TestNG DataProviders and other improvements. LGTM. test/jdk/java/lang/RuntimeTests/exec/ExecComman

RFR: 8273242: (test) Refactor to use TestNG for RuntimeTests ExecCommand tests

2021-09-01 Thread Roger Riggs
The ExecCommand test of Runtime.exec is difficult to maintain; the parallel arrays are hard to keep in sync. This cleanup converts to use TestNG DataProviders and other improvements. - Commit messages: - 8273242: Refactored ExecCommand to use TestNG DataProvider for cases Changes: