> Please review the fix to the issue. Avoiding overflow by not calling
> nanosUntil() directly, which will overflow beyond Long.MAX_VALUE difference
> in nano unit.
Naoto Sato has updated the pull request incrementally with one additional
commit since the last revision:
Added comments for th
On Wed, 8 Sep 2021 00:36:29 GMT, Naoto Sato wrote:
>> Please review the fix to the issue. Avoiding overflow by not calling
>> nanosUntil() directly, which will overflow beyond Long.MAX_VALUE difference
>> in nano unit.
>
> Naoto Sato has updated the pull request incrementally with one additiona
On Wed, 8 Sep 2021 00:36:29 GMT, Naoto Sato wrote:
>> Please review the fix to the issue. Avoiding overflow by not calling
>> nanosUntil() directly, which will overflow beyond Long.MAX_VALUE difference
>> in nano unit.
>
> Naoto Sato has updated the pull request incrementally with one additiona
On Wed, 8 Sep 2021 00:36:29 GMT, Naoto Sato wrote:
>> Please review the fix to the issue. Avoiding overflow by not calling
>> nanosUntil() directly, which will overflow beyond Long.MAX_VALUE difference
>> in nano unit.
>
> Naoto Sato has updated the pull request incrementally with one additiona
On Wed, 8 Sep 2021 13:58:59 GMT, Stephen Colebourne
wrote:
> This change looks fine, but I think you also need a `millisUntil` private
> method to fix the identical overflow problem with millis (which might as well
> be fixed now).
`until()` for millis simply subtracts its `toEpochMilli()` fr
On Wed, 8 Sep 2021 00:36:29 GMT, Naoto Sato wrote:
>> Please review the fix to the issue. Avoiding overflow by not calling
>> nanosUntil() directly, which will overflow beyond Long.MAX_VALUE difference
>> in nano unit.
>
> Naoto Sato has updated the pull request incrementally with one additiona
On Wed, 8 Sep 2021 15:35:27 GMT, Stephen Colebourne
wrote:
> `toEpochMilli()` overflows at large/small values. Thus any attempt to
> calculate the difference between two very large instants would fail.
Thanks. Fixed.
-
PR: https://git.openjdk.java.net/jdk/pull/5396
