Re: RFR: 8273491: java.util.spi.LocaleServiceProvider spec contains statement that is too strict [v2]

2021-09-11 Thread Lance Andersen
On Sat, 11 Sep 2021 13:59:25 GMT, Naoto Sato wrote: >> That sounds good to me, suggesting doing it at launch while discouraging the >> use of setProperty. > > Hi Lance, > >> * Are there any scenarios where invoking setProperty will not override the >> command line setting ? > > Yes. For

Re: RFR: 8273491: java.util.spi.LocaleServiceProvider spec contains statement that is too strict [v2]

2021-09-11 Thread Lance Andersen
On Fri, 10 Sep 2021 20:35:25 GMT, Naoto Sato wrote: >> Small spec clarification. Corresponding CSR has also been drafted. > > Naoto Sato has updated the pull request incrementally with one additional > commit since the last revision: > > Reflecting review comment. Marked as reviewed by

Re: RFR: 8273491: java.util.spi.LocaleServiceProvider spec contains statement that is too strict [v2]

2021-09-11 Thread Naoto Sato
On Fri, 10 Sep 2021 20:53:35 GMT, Joe Wang wrote: >> Hi Naoto, >> >> A couple of questions: >> >> - Are there any scenarios where invoking setProperty will not override the >> command line setting ? >> - Did you consider an `@ImplNote` for your clarification given the behavior >> "might" be

Re: RFR: 8273491: java.util.spi.LocaleServiceProvider spec contains statement that is too strict [v2]

2021-09-11 Thread Lance Andersen
On Fri, 10 Sep 2021 20:32:03 GMT, Naoto Sato wrote: >> src/java.base/share/classes/java/util/spi/LocaleServiceProvider.java line >> 120: >> >>> 118: * the locale sensitive services separated by a comma. It is only read >>> and cached at >>> 119: * the initialization of this class, so the

Re: RFR: 8273491: java.util.spi.LocaleServiceProvider spec contains statement that is too strict [v2]

2021-09-10 Thread Joe Wang
On Fri, 10 Sep 2021 20:32:03 GMT, Naoto Sato wrote: >> src/java.base/share/classes/java/util/spi/LocaleServiceProvider.java line >> 120: >> >>> 118: * the locale sensitive services separated by a comma. It is only read >>> and cached at >>> 119: * the initialization of this class, so the

Re: RFR: 8273491: java.util.spi.LocaleServiceProvider spec contains statement that is too strict [v2]

2021-09-10 Thread Joe Wang
On Fri, 10 Sep 2021 20:35:25 GMT, Naoto Sato wrote: >> Small spec clarification. Corresponding CSR has also been drafted. > > Naoto Sato has updated the pull request incrementally with one additional > commit since the last revision: > > Reflecting review comment. Marked as reviewed by

Re: RFR: 8273491: java.util.spi.LocaleServiceProvider spec contains statement that is too strict [v2]

2021-09-10 Thread Naoto Sato
On Fri, 10 Sep 2021 18:11:37 GMT, Joe Wang wrote: >> Naoto Sato has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Reflecting review comment. > > src/java.base/share/classes/java/util/spi/LocaleServiceProvider.java line 120: > >> 118: *

Re: RFR: 8273491: java.util.spi.LocaleServiceProvider spec contains statement that is too strict [v2]

2021-09-10 Thread Naoto Sato
> Small spec clarification. Corresponding CSR has also been drafted. Naoto Sato has updated the pull request incrementally with one additional commit since the last revision: Reflecting review comment. - Changes: - all: https://git.openjdk.java.net/jdk/pull/5457/files - new:

Re: RFR: 8273491: java.util.spi.LocaleServiceProvider spec contains statement that is too strict

2021-09-10 Thread Joe Wang
On Thu, 9 Sep 2021 23:29:24 GMT, Naoto Sato wrote: > Small spec clarification. Corresponding CSR has also been drafted. src/java.base/share/classes/java/util/spi/LocaleServiceProvider.java line 120: > 118: * the locale sensitive services separated by a comma. It is only read > and cached at

RFR: 8273491: java.util.spi.LocaleServiceProvider spec contains statement that is too strict

2021-09-09 Thread Naoto Sato
Small spec clarification. Corresponding CSR has also been drafted. - Commit messages: - 8273491: java.util.spi.LocaleServiceProvider spec contains statement that is too strict Changes: https://git.openjdk.java.net/jdk/pull/5457/files Webrev: