Re: RFR: 8274750: java/io/File/GetXSpace.java failed: '/dev': 191488 != 190976 [v3]

2021-10-28 Thread Roger Riggs
On Thu, 28 Oct 2021 21:21:38 GMT, Brian Burkhalter wrote: >> Please consider this proposed change to ignore comparing the total size of >> `/dev` as returned by `DF(1)` and `STAT(2)` on macOS. > > Brian Burkhalter has updated the pull request incrementally with one > additional commit since

Re: RFR: 8274750: java/io/File/GetXSpace.java failed: '/dev': 191488 != 190976 [v3]

2021-10-28 Thread Brian Burkhalter
> Please consider this proposed change to ignore comparing the total size of > `/dev` as returned by `DF(1)` and `STAT(2)` on macOS. Brian Burkhalter has updated the pull request incrementally with one additional commit since the last revision: 8274750: Suppress compilation warning about

Re: RFR: 8274750: java/io/File/GetXSpace.java failed: '/dev': 191488 != 190976 [v2]

2021-10-28 Thread Brian Burkhalter
On Thu, 28 Oct 2021 19:33:06 GMT, Roger Riggs wrote: >> Brian Burkhalter has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8274750: Change location of check that file system is not /dev on macOS > > LTGM > > (While you're in there you

Re: RFR: 8274750: java/io/File/GetXSpace.java failed: '/dev': 191488 != 190976 [v2]

2021-10-28 Thread Naoto Sato
On Thu, 28 Oct 2021 18:15:33 GMT, Brian Burkhalter wrote: >> Please consider this proposed change to ignore comparing the total size of >> `/dev` as returned by `DF(1)` and `STAT(2)` on macOS. > > Brian Burkhalter has updated the pull request incrementally with one > additional commit since

Re: RFR: 8274750: java/io/File/GetXSpace.java failed: '/dev': 191488 != 190976 [v2]

2021-10-28 Thread Roger Riggs
On Thu, 28 Oct 2021 18:15:33 GMT, Brian Burkhalter wrote: >> Please consider this proposed change to ignore comparing the total size of >> `/dev` as returned by `DF(1)` and `STAT(2)` on macOS. > > Brian Burkhalter has updated the pull request incrementally with one > additional commit since

Re: RFR: 8274750: java/io/File/GetXSpace.java failed: '/dev': 191488 != 190976 [v2]

2021-10-28 Thread Brian Burkhalter
On Tue, 26 Oct 2021 20:27:47 GMT, Brian Burkhalter wrote: >> test/jdk/java/io/File/GetXSpace.java line 210: >> >>> 208: if (Platform.isOSX() && s.name().equals("/dev")) { >>> 209: out.println("/dev:\n Skipping size comparison for /dev on >>> macOS"); >>> 210:

Re: RFR: 8274750: java/io/File/GetXSpace.java failed: '/dev': 191488 != 190976

2021-10-28 Thread Brian Burkhalter
On Tue, 26 Oct 2021 19:00:44 GMT, Brian Burkhalter wrote: > Please consider this proposed change to ignore comparing the total size of > `/dev` as returned by `DF(1)` and `STAT(2)` on macOS. Please refer to the issue for more detail, but this change is proposed because the total size of

Re: RFR: 8274750: java/io/File/GetXSpace.java failed: '/dev': 191488 != 190976 [v2]

2021-10-28 Thread Brian Burkhalter
> Please consider this proposed change to ignore comparing the total size of > `/dev` as returned by `DF(1)` and `STAT(2)` on macOS. Brian Burkhalter has updated the pull request incrementally with one additional commit since the last revision: 8274750: Change location of check that file

Re: RFR: 8274750: java/io/File/GetXSpace.java failed: '/dev': 191488 != 190976

2021-10-26 Thread Brian Burkhalter
On Tue, 26 Oct 2021 20:24:28 GMT, Naoto Sato wrote: >> Please consider this proposed change to ignore comparing the total size of >> `/dev` as returned by `DF(1)` and `STAT(2)` on macOS. > > test/jdk/java/io/File/GetXSpace.java line 210: > >> 208: if (Platform.isOSX() &&

Re: RFR: 8274750: java/io/File/GetXSpace.java failed: '/dev': 191488 != 190976

2021-10-26 Thread Naoto Sato
On Tue, 26 Oct 2021 19:00:44 GMT, Brian Burkhalter wrote: > Please consider this proposed change to ignore comparing the total size of > `/dev` as returned by `DF(1)` and `STAT(2)` on macOS. test/jdk/java/io/File/GetXSpace.java line 210: > 208: if (Platform.isOSX() &&

Re: RFR: 8274750: java/io/File/GetXSpace.java failed: '/dev': 191488 != 190976

2021-10-26 Thread Brian Burkhalter
On Tue, 26 Oct 2021 19:00:44 GMT, Brian Burkhalter wrote: > Please consider this proposed change to ignore comparing the total size of > `/dev` as returned by `DF(1)` and `STAT(2)` on macOS. Alternative approaches would be to compare `File.getTotalSpace()` with `FileStore.getTotalSpace()` and

RFR: 8274750: java/io/File/GetXSpace.java failed: '/dev': 191488 != 190976

2021-10-26 Thread Brian Burkhalter
Please consider this proposed change to ignore comparing the total size of `/dev` as returned by `DF(1)` and `STAT(2)` on macOS. - Commit messages: - 8274750: java/io/File/GetXSpace.java failed: '/dev': 191488 != 190976 Changes: https://git.openjdk.java.net/jdk/pull/6122/files