Re: RFR: 8276141: XPathFactory set/getProperty method [v2]

2021-11-05 Thread Joe Wang
On Fri, 5 Nov 2021 17:08:02 GMT, Joe Wang wrote: >> src/java.xml/share/classes/javax/xml/xpath/XPathFactory.java line 412: >> >>> 410: * >>> 411: * @throws XPathFactoryConfigurationException if the property name >>> is not >>> 412: * recognized >> >> Are you sure XPathFactoryCon

Re: RFR: 8276141: XPathFactory set/getProperty method [v2]

2021-11-05 Thread Joe Wang
On Fri, 5 Nov 2021 11:02:37 GMT, Alan Bateman wrote: >> Joe Wang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Add default impl; Add tests. > > src/java.xml/share/classes/javax/xml/xpath/XPathFactory.java line 412: > >> 410: * >>

Re: RFR: 8276141: XPathFactory set/getProperty method [v2]

2021-11-05 Thread Joe Wang
On Fri, 5 Nov 2021 10:59:44 GMT, Alan Bateman wrote: >> Joe Wang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Add default impl; Add tests. > > src/java.xml/share/classes/javax/xml/xpath/XPathFactory.java line 406: > >> 404: * @i

Re: RFR: 8276141: XPathFactory set/getProperty method [v2]

2021-11-05 Thread Alan Bateman
On Wed, 3 Nov 2021 01:10:46 GMT, Joe Wang wrote: >> Add setProperty/getProperty methods to the XPath API so that properties can >> be supported in the future. > > Joe Wang has updated the pull request incrementally with one additional > commit since the last revision: > > Add default impl; A

Re: RFR: 8276141: XPathFactory set/getProperty method [v2]

2021-11-02 Thread Joe Wang
On Wed, 3 Nov 2021 01:10:46 GMT, Joe Wang wrote: >> Add setProperty/getProperty methods to the XPath API so that properties can >> be supported in the future. > > Joe Wang has updated the pull request incrementally with one additional > commit since the last revision: > > Add default impl; A

Re: RFR: 8276141: XPathFactory set/getProperty method [v2]

2021-11-02 Thread Joe Wang
> Add setProperty/getProperty methods to the XPath API so that properties can > be supported in the future. Joe Wang has updated the pull request incrementally with one additional commit since the last revision: Add default impl; Add tests. - Changes: - all: https://git.openjd