On Mon, 1 Nov 2021 16:51:36 GMT, Pavel Rappo wrote:
>> Please review this PR. A comprehensive test job has been scheduled; I'll
>> notify this thread once that job has completed.
>
> Pavel Rappo has updated the pull request incrementally with one additional
> commit since the last revision:
>
On Mon, 1 Nov 2021 16:51:36 GMT, Pavel Rappo wrote:
>> Please review this PR. A comprehensive test job has been scheduled; I'll
>> notify this thread once that job has completed.
>
> Pavel Rappo has updated the pull request incrementally with one additional
> commit since the last revision:
>
On Mon, 1 Nov 2021 16:25:26 GMT, Pavel Rappo wrote:
>> src/java.base/share/classes/sun/util/resources/LocaleData.java line 248:
>>
>>> 246: private static final LocaleDataStrategy INSTANCE = new
>>> LocaleDataStrategy();
>>> 247: // TODO: avoid hard-coded Locales
>>> 248:
> Please review this PR. A comprehensive test job has been scheduled; I'll
> notify this thread once that job has completed.
Pavel Rappo has updated the pull request incrementally with one additional
commit since the last revision:
Use the blessed modifiers order
-
Changes:
-
On Mon, 1 Nov 2021 15:23:49 GMT, Claes Redestad wrote:
>> Please review this PR. A comprehensive test job has been scheduled; I'll
>> notify this thread once that job has completed.
>
> src/java.base/share/classes/sun/util/resources/LocaleData.java line 248:
>
>> 246: private static
On Mon, 1 Nov 2021 15:52:51 GMT, Daniel Fuchs wrote:
>> Please review this PR. A comprehensive test job has been scheduled; I'll
>> notify this thread once that job has completed.
>
> src/java.base/share/classes/sun/util/resources/LocaleData.java line 336:
>
>> 334: public List
On Mon, 1 Nov 2021 15:04:16 GMT, Pavel Rappo wrote:
> Please review this PR. A comprehensive test job has been scheduled; I'll
> notify this thread once that job has completed.
Marked as reviewed by naoto (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/6191
On Mon, 1 Nov 2021 15:04:16 GMT, Pavel Rappo wrote:
> Please review this PR. A comprehensive test job has been scheduled; I'll
> notify this thread once that job has completed.
src/java.base/share/classes/sun/util/resources/LocaleData.java line 336:
> 334: public List
On Mon, 1 Nov 2021 15:04:16 GMT, Pavel Rappo wrote:
> Please review this PR. A comprehensive test job has been scheduled; I'll
> notify this thread once that job has completed.
LGTM, but please use `static final`
src/java.base/share/classes/sun/util/resources/LocaleData.java line 248:
> 246:
Please review this PR. A comprehensive test job has been scheduled; I'll notify
this thread once that job has completed.
-
Commit messages:
- Fix *code* typo
- Be more immutable
- Fix typos
Changes: https://git.openjdk.java.net/jdk/pull/6191/files
Webrev:
10 matches
Mail list logo