Re: RFR: 8276970: Default charset for PrintWriter that wraps PrintStream [v3]

2021-11-17 Thread Ichiroh Takiguchi
On Thu, 18 Nov 2021 00:11:49 GMT, Naoto Sato wrote: > > BTW, I still observe on Windows (system locale=ja-JP): > > ``` > > D:\projects\jdk\git\jdk>.\build\windows-x64\jdk\bin\jshell > > -J-Duser.language=ja > > | JShellへようこそ -- バージョン18-internal > > | 概要については、次を入力してください: /help intro > > > > js

Re: RFR: 8276970: Default charset for PrintWriter that wraps PrintStream [v3]

2021-11-17 Thread Naoto Sato
On Tue, 16 Nov 2021 21:49:55 GMT, Naoto Sato wrote: > BTW, I still observe on Windows (system locale=ja-JP): > > ``` > D:\projects\jdk\git\jdk>.\build\windows-x64\jdk\bin\jshell > -J-Duser.language=ja > | JShellへようこそ -- バージョン18-internal > | 概要については、次を入力してください: /help intro > > jshell> System.

Re: RFR: 8276970: Default charset for PrintWriter that wraps PrintStream [v3]

2021-11-17 Thread Roger Riggs
On Tue, 16 Nov 2021 21:09:08 GMT, Naoto Sato wrote: >> Fixing the default charset for PrintWriter/OutputStreamWriter that wraps a >> PrintStream to its charset. This issue was raised during the conversations >> in https://github.com/openjdk/jdk/pull/5771 >> A corresponding CSR has also been dra

Re: RFR: 8276970: Default charset for PrintWriter that wraps PrintStream [v3]

2021-11-16 Thread Alan Bateman
On Tue, 16 Nov 2021 21:09:08 GMT, Naoto Sato wrote: >> Fixing the default charset for PrintWriter/OutputStreamWriter that wraps a >> PrintStream to its charset. This issue was raised during the conversations >> in https://github.com/openjdk/jdk/pull/5771 >> A corresponding CSR has also been dra

Re: RFR: 8276970: Default charset for PrintWriter that wraps PrintStream [v3]

2021-11-16 Thread Naoto Sato
On Tue, 16 Nov 2021 21:09:08 GMT, Naoto Sato wrote: >> Fixing the default charset for PrintWriter/OutputStreamWriter that wraps a >> PrintStream to its charset. This issue was raised during the conversations >> in https://github.com/openjdk/jdk/pull/5771 >> A corresponding CSR has also been dra

Re: RFR: 8276970: Default charset for PrintWriter that wraps PrintStream [v2]

2021-11-16 Thread Naoto Sato
On Tue, 16 Nov 2021 20:10:53 GMT, Alan Bateman wrote: >> Naoto Sato has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Made PrintStream::charset() public, charset field final, and refined >> wordings. > > src/java.base/share/classes/java/i

Re: RFR: 8276970: Default charset for PrintWriter that wraps PrintStream [v3]

2021-11-16 Thread Naoto Sato
> Fixing the default charset for PrintWriter/OutputStreamWriter that wraps a > PrintStream to its charset. This issue was raised during the conversations in > https://github.com/openjdk/jdk/pull/5771 > A corresponding CSR has also been drafted: > https://bugs.openjdk.java.net/browse/JDK-8277078

Re: RFR: 8276970: Default charset for PrintWriter that wraps PrintStream [v2]

2021-11-16 Thread Alan Bateman
On Tue, 16 Nov 2021 18:08:08 GMT, Naoto Sato wrote: >> Fixing the default charset for PrintWriter/OutputStreamWriter that wraps a >> PrintStream to its charset. This issue was raised during the conversations >> in https://github.com/openjdk/jdk/pull/5771 >> A corresponding CSR has also been dra

Re: RFR: 8276970: Default charset for PrintWriter that wraps PrintStream [v2]

2021-11-16 Thread Roger Riggs
On Tue, 16 Nov 2021 18:08:08 GMT, Naoto Sato wrote: >> Fixing the default charset for PrintWriter/OutputStreamWriter that wraps a >> PrintStream to its charset. This issue was raised during the conversations >> in https://github.com/openjdk/jdk/pull/5771 >> A corresponding CSR has also been dra

Re: RFR: 8276970: Default charset for PrintWriter that wraps PrintStream [v2]

2021-11-16 Thread Naoto Sato
> Fixing the default charset for PrintWriter/OutputStreamWriter that wraps a > PrintStream to its charset. This issue was raised during the conversations in > https://github.com/openjdk/jdk/pull/5771 > A corresponding CSR has also been drafted: > https://bugs.openjdk.java.net/browse/JDK-8277078

Re: RFR: 8276970: Default charset for PrintWriter that wraps PrintStream

2021-11-16 Thread Alan Bateman
On Tue, 16 Nov 2021 17:27:21 GMT, Naoto Sato wrote: > Also I am tempted to make `PrintStream::charset()` public, as some custom > `OutputStreamWriter` implementations would also need the charset information. I think that would be good addition. - PR: https://git.openjdk.java.net/j

Re: RFR: 8276970: Default charset for PrintWriter that wraps PrintStream

2021-11-16 Thread Naoto Sato
On Tue, 16 Nov 2021 05:25:33 GMT, Jaikiran Pai wrote: >> Fixing the default charset for PrintWriter/OutputStreamWriter that wraps a >> PrintStream to its charset. This issue was raised during the conversations >> in https://github.com/openjdk/jdk/pull/5771 >> A corresponding CSR has also been d

Re: RFR: 8276970: Default charset for PrintWriter that wraps PrintStream

2021-11-16 Thread Naoto Sato
On Tue, 16 Nov 2021 12:21:20 GMT, Alan Bateman wrote: >> Fixing the default charset for PrintWriter/OutputStreamWriter that wraps a >> PrintStream to its charset. This issue was raised during the conversations >> in https://github.com/openjdk/jdk/pull/5771 >> A corresponding CSR has also been d

Re: RFR: 8276970: Default charset for PrintWriter that wraps PrintStream

2021-11-16 Thread Naoto Sato
On Tue, 16 Nov 2021 10:37:12 GMT, Ichiroh Takiguchi wrote: > I tested some of java tool commands on #5771 . > > > jar.exe, javac.exe, javadoc.exe, javap.exe, jdeps.exe, jlink.exe, jmod.exe, > > jpackage.exe > > It worked fine as expected on CentOS7 (ja_JP.eucjp locale) and Windows 10 Pro > f

Re: RFR: 8276970: Default charset for PrintWriter that wraps PrintStream

2021-11-16 Thread Alan Bateman
On Mon, 15 Nov 2021 22:43:37 GMT, Naoto Sato wrote: > Fixing the default charset for PrintWriter/OutputStreamWriter that wraps a > PrintStream to its charset. This issue was raised during the conversations in > https://github.com/openjdk/jdk/pull/5771 > A corresponding CSR has also been drafted

Re: RFR: 8276970: Default charset for PrintWriter that wraps PrintStream

2021-11-16 Thread Ichiroh Takiguchi
On Mon, 15 Nov 2021 22:43:37 GMT, Naoto Sato wrote: > Fixing the default charset for PrintWriter/OutputStreamWriter that wraps a > PrintStream to its charset. This issue was raised during the conversations in > https://github.com/openjdk/jdk/pull/5771 > A corresponding CSR has also been drafted

Re: RFR: 8276970: Default charset for PrintWriter that wraps PrintStream

2021-11-15 Thread Jaikiran Pai
On Mon, 15 Nov 2021 22:43:37 GMT, Naoto Sato wrote: > Fixing the default charset for PrintWriter/OutputStreamWriter that wraps a > PrintStream to its charset. This issue was raised during the conversations in > https://github.com/openjdk/jdk/pull/5771 > A corresponding CSR has also been drafted

RFR: 8276970: Default charset for PrintWriter that wraps PrintStream

2021-11-15 Thread Naoto Sato
Fixing the default charset for PrintWriter/OutputStreamWriter that wraps a PrintStream to its charset. This issue was raised during the conversations in https://github.com/openjdk/jdk/pull/5771 A corresponding CSR has also been drafted: https://bugs.openjdk.java.net/browse/JDK-8277078 -