On Mon, 7 Mar 2022 17:04:25 GMT, Joe Wang wrote:
>> Is `IsoBased` is fine with me. "isISOLike" is too vague.
>
> That matches the javadoc as well, that it "supports ISO based fields".
Renamed the new method to `isIsoBased()`. Modified the CSR accordingly.
-
PR:
On Mon, 7 Mar 2022 03:00:45 GMT, Roger Riggs wrote:
>> OK, I propose `isIsoBased()` for the name, which I initially thought of. If
>> there is no objection, I will modify the spec/impl.
>
> Is `IsoBased` is fine with me. "isISOLike" is too vague.
That matches the javadoc as well, that it
On Mon, 7 Mar 2022 01:27:39 GMT, Naoto Sato wrote:
>> src/java.base/share/classes/java/time/chrono/Chronology.java line 794:
>>
>>> 792: * @since 19
>>> 793: */
>>> 794: default boolean supportsIsoFields() {
>>
>> I'm not a fan of this name, as it is inconsistent with the rest of
On Sun, 6 Mar 2022 17:12:31 GMT, Stephen Colebourne
wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Addresses review comments
>
> src/java.base/share/classes/java/time/chrono/Chronology.java line 794:
>
>> 792:
On Fri, 4 Mar 2022 23:05:56 GMT, Naoto Sato wrote:
>> Supporting `IsoFields` temporal fields in chronologies that are similar to
>> ISO chronology. Corresponding CSR has also been drafted.
>
> Naoto Sato has updated the pull request incrementally with one additional
> commit since the last
> Supporting `IsoFields` temporal fields in chronologies that are similar to
> ISO chronology. Corresponding CSR has also been drafted.
Naoto Sato has updated the pull request incrementally with one additional
commit since the last revision:
Addresses review comments
-
Changes: