On Thu, 3 Mar 2022 05:42:23 GMT, Jatin Bhateja wrote:
>> The testing for this PR doesn't look adequate to me. I don't see any testing
>> for the values where the behavior of round has been redefined at points in
>> the last decade. See JDK-8010430 and JDK-6430675, both of which have
>> regress
On Wed, 19 Jan 2022 22:09:26 GMT, Joe Darcy wrote:
>> Jatin Bhateja has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8279508: Adding a test for scalar intrinsification.
>
> The testing for this PR doesn't look adequate to me. I don't see
On 2/12/2022 6:55 PM, Jatin Bhateja wrote:
On Fri, 21 Jan 2022 00:49:04 GMT, Sandhya Viswanathan
wrote:
The JVM currently initializes the x86 mxcsr to round to nearest even, see below
in stubGenerator_x86_64.cpp: // Round to nearest (even), 64-bit mode,
exceptions masked StubRoutines::x86
On Fri, 21 Jan 2022 00:49:04 GMT, Sandhya Viswanathan
wrote:
> The JVM currently initializes the x86 mxcsr to round to nearest even, see
> below in stubGenerator_x86_64.cpp: // Round to nearest (even), 64-bit mode,
> exceptions masked StubRoutines::x86::_mxcsr_std = 0x1F80; The above works for
On Wed, 19 Jan 2022 17:38:25 GMT, Jatin Bhateja wrote:
>> Summary of changes:
>> - Intrinsify Math.round(float) and Math.round(double) APIs.
>> - Extend auto-vectorizer to infer vector operations on encountering scalar
>> IR nodes for above intrinsics.
>> - Test creation using new IR testing fra
On Wed, 19 Jan 2022 17:38:25 GMT, Jatin Bhateja wrote:
>> Summary of changes:
>> - Intrinsify Math.round(float) and Math.round(double) APIs.
>> - Extend auto-vectorizer to infer vector operations on encountering scalar
>> IR nodes for above intrinsics.
>> - Test creation using new IR testing fra
On Wed, 19 Jan 2022 17:38:25 GMT, Jatin Bhateja wrote:
>> Summary of changes:
>> - Intrinsify Math.round(float) and Math.round(double) APIs.
>> - Extend auto-vectorizer to infer vector operations on encountering scalar
>> IR nodes for above intrinsics.
>> - Test creation using new IR testing fra
> Summary of changes:
> - Intrinsify Math.round(float) and Math.round(double) APIs.
> - Extend auto-vectorizer to infer vector operations on encountering scalar IR
> nodes for above intrinsics.
> - Test creation using new IR testing framework.
>
> Following are the performance number of a JMH mic