Re: RFR: 8279598: Provide adapter from RandomGenerator to Random [v19]

2022-04-20 Thread Yasser Bazzi
On Wed, 16 Mar 2022 14:54:41 GMT, Yasser Bazzi wrote: >> Hi, could i get a review on this implementation proposed by Stuart Marks, i >> decided to use the >> https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/util/random/RandomGenerator.html >> interface to create the default me

Re: RFR: 8279598: Provide adapter from RandomGenerator to Random [v19]

2022-03-18 Thread Stuart Marks
On Wed, 16 Mar 2022 14:54:41 GMT, Yasser Bazzi wrote: >> Hi, could i get a review on this implementation proposed by Stuart Marks, i >> decided to use the >> https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/util/random/RandomGenerator.html >> interface to create the default me

Re: RFR: 8279598: Provide adapter from RandomGenerator to Random [v19]

2022-03-18 Thread liach
On Fri, 18 Mar 2022 19:11:45 GMT, jmehrens wrote: > > you are not expected to inspect a random object by its string. > > ToString representations tend to show up in exception messages and logging. > > Seems like this adapter just won't adapt that call. Not a deal breaker. > > > Also the rever

Re: RFR: 8279598: Provide adapter from RandomGenerator to Random [v19]

2022-03-18 Thread jmehrens
On Fri, 18 Mar 2022 13:10:10 GMT, liach wrote: >you are not expected to inspect a random object by its string. ToString representations tend to show up in exception messages and logging. Seems like this adapter just won't adapt that call. Not a deal breaker. > Also the reverse order comparat

Re: RFR: 8279598: Provide adapter from RandomGenerator to Random [v19]

2022-03-18 Thread liach
On Fri, 18 Mar 2022 13:06:12 GMT, jmehrens wrote: > > The toString method of both classes do not implement anything so i dont > > think we should override it, > > The inherited implementation is descriptive enough because the the class > names are the implementation: > https://github.com

Re: RFR: 8279598: Provide adapter from RandomGenerator to Random [v19]

2022-03-18 Thread jmehrens
On Fri, 18 Mar 2022 00:24:56 GMT, Yasser Bazzi wrote: > The toString method of both classes do not implement anything so i dont think > we should override it, The inherited implementation is descriptive enough because the the class names are the implementation: https://github.com/openjdk/

Re: RFR: 8279598: Provide adapter from RandomGenerator to Random [v19]

2022-03-17 Thread Joe Darcy
On Wed, 16 Mar 2022 14:54:41 GMT, Yasser Bazzi wrote: >> Hi, could i get a review on this implementation proposed by Stuart Marks, i >> decided to use the >> https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/util/random/RandomGenerator.html >> interface to create the default me

Re: RFR: 8279598: Provide adapter from RandomGenerator to Random [v19]

2022-03-17 Thread liach
On Wed, 16 Mar 2022 14:54:41 GMT, Yasser Bazzi wrote: >> Hi, could i get a review on this implementation proposed by Stuart Marks, i >> decided to use the >> https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/util/random/RandomGenerator.html >> interface to create the default me

Re: RFR: 8279598: Provide adapter from RandomGenerator to Random [v19]

2022-03-17 Thread Yasser Bazzi
On Wed, 16 Mar 2022 14:54:41 GMT, Yasser Bazzi wrote: >> Hi, could i get a review on this implementation proposed by Stuart Marks, i >> decided to use the >> https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/util/random/RandomGenerator.html >> interface to create the default me

Re: RFR: 8279598: Provide adapter from RandomGenerator to Random [v19]

2022-03-17 Thread jmehrens
On Wed, 16 Mar 2022 14:54:41 GMT, Yasser Bazzi wrote: >> Hi, could i get a review on this implementation proposed by Stuart Marks, i >> decided to use the >> https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/util/random/RandomGenerator.html >> interface to create the default me

Re: RFR: 8279598: Provide adapter from RandomGenerator to Random [v19]

2022-03-17 Thread liach
On Wed, 16 Mar 2022 14:54:41 GMT, Yasser Bazzi wrote: >> Hi, could i get a review on this implementation proposed by Stuart Marks, i >> decided to use the >> https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/util/random/RandomGenerator.html >> interface to create the default me

Re: RFR: 8279598: Provide adapter from RandomGenerator to Random [v19]

2022-03-16 Thread Stuart Marks
On Wed, 16 Mar 2022 14:54:41 GMT, Yasser Bazzi wrote: >> Hi, could i get a review on this implementation proposed by Stuart Marks, i >> decided to use the >> https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/util/random/RandomGenerator.html >> interface to create the default me

Re: RFR: 8279598: Provide adapter from RandomGenerator to Random [v19]

2022-03-16 Thread Yasser Bazzi
> Hi, could i get a review on this implementation proposed by Stuart Marks, i > decided to use the > https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/util/random/RandomGenerator.html > interface to create the default method `asRandom()` that wraps around the > newer algorithms