On Fri, 4 Mar 2022 21:02:50 GMT, Stuart Marks wrote:
>>> This actually tests three things: 1) table is lazily allocated, 2) default
>>> capacity is 16, and 3) using putAll to populate the map with 64 elements
>>> results in a table size of 128. This should really be broken into three
>>>
On Fri, 4 Mar 2022 20:23:38 GMT, XenoAmess wrote:
> would you mind if I break WhiteBoxResizeTest class into several smaller Test
> classes, each focus on one of the test points you said?
Well, separate classes wouldn't be the approach that I'd take myself. However,
I'm interested in you
On Fri, 4 Mar 2022 20:05:23 GMT, Stuart Marks wrote:
> This actually tests three things: 1) table is lazily allocated, 2) default
> capacity is 16, and 3) using putAll to populate the map with 64 elements
> results in a table size of 128. This should really be broken into three
> separate
On Fri, 4 Mar 2022 17:30:48 GMT, XenoAmess wrote:
>> 8281631: HashMap copy constructor and putAll can over-allocate table
>
> XenoAmess has updated the pull request incrementally with one additional
> commit since the last revision:
>
> refine test
> I see codes WhiteBoxResizeTest. If you
On Fri, 4 Mar 2022 17:43:25 GMT, liach wrote:
> nitpick for the test code: for better performance, move method handle and var
> handle to static final fields so the jvm can run faster
will do it when we really migrate this test, but it should be done in another
pr when I add WeakHashMap's
On Fri, 4 Mar 2022 17:30:48 GMT, XenoAmess wrote:
>> 8281631: HashMap copy constructor and putAll can over-allocate table
>
> XenoAmess has updated the pull request incrementally with one additional
> commit since the last revision:
>
> refine test
nitpick for the test code: for better
> 8281631: HashMap copy constructor and putAll can over-allocate table
XenoAmess has updated the pull request incrementally with one additional commit
since the last revision:
refine test
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/7431/files
- new: