On Fri, 25 Feb 2022 04:44:45 GMT, Naoto Sato wrote:
>> That's a very good point. I've updated the PR to now explicitly use a
>> mutable `Set` instead of using `Collectors.toSet()`
>
> This is ok, although `Collectors.toCollection(HashSet::new)` is a bit concise.
Hello Naoto, I've updated the PR
On Fri, 25 Feb 2022 03:51:09 GMT, Jaikiran Pai wrote:
>> test/jdk/java/util/Properties/PropertiesStoreTest.java line 112:
>>
>>> 110: locales.add(Locale.getDefault()); // always test the default
>>> locale
>>> 111: locales.add(Locale.US); // guaranteed to be present
>>> 112:
On Thu, 24 Feb 2022 17:15:16 GMT, Naoto Sato wrote:
>> Jaikiran Pai has updated the pull request incrementally with four additional
>> commits since the last revision:
>>
>> - use Roger's suggestion of using Stream and Collection based APIs to avoid
>> code duplication in the data provider me
On Thu, 24 Feb 2022 05:02:47 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this test only change which fixes the issue
>> noted in https://bugs.openjdk.java.net/browse/JDK-8282023?
>>
>> As noted in that JBS issue these tests fail when the default locale under
>> which those tests a
> Can I please get a review of this test only change which fixes the issue
> noted in https://bugs.openjdk.java.net/browse/JDK-8282023?
>
> As noted in that JBS issue these tests fail when the default locale under
> which those tests are run isn't `en_US`. Both these tests were introduced as
>
