Re: RFR: 8282081: java.time.DateTimeFormatter: wrong definition of symbol F

2022-03-01 Thread Naoto Sato
On Tue, 1 Mar 2022 11:22:35 GMT, Lance Andersen wrote: > Are there any TCK tests that need to be modified or Added? I made a very > quick scan of the open/test/jdk/java/time/tck/java/time/ dirs and did not see > any tests but of course I could have missed it There are test cases in the `TCK` d

Re: RFR: 8282081: java.time.DateTimeFormatter: wrong definition of symbol F

2022-03-01 Thread Roger Riggs
On Mon, 28 Feb 2022 23:17:57 GMT, Naoto Sato wrote: > Fixing the definition and implementation of the pattern symbol `F`. Although > it is an incompatible change, I believe it is worth the fix. For that, a CSR > has been drafted. Marked as reviewed by rriggs (Reviewer). - PR: htt

Re: RFR: 8282081: java.time.DateTimeFormatter: wrong definition of symbol F

2022-03-01 Thread Lance Andersen
On Mon, 28 Feb 2022 23:17:57 GMT, Naoto Sato wrote: > Fixing the definition and implementation of the pattern symbol `F`. Although > it is an incompatible change, I believe it is worth the fix. For that, a CSR > has been drafted. I think the change makes sense. Are there any TCK tests that ne

Re: RFR: 8282081: java.time.DateTimeFormatter: wrong definition of symbol F

2022-02-28 Thread Stephen Colebourne
On Mon, 28 Feb 2022 23:17:57 GMT, Naoto Sato wrote: > Fixing the definition and implementation of the pattern symbol `F`. Although > it is an incompatible change, I believe it is worth the fix. For that, a CSR > has been drafted. Although there is incompatibility, I believe a fix is the correc

Re: RFR: 8282081: java.time.DateTimeFormatter: wrong definition of symbol F

2022-02-28 Thread Joe Wang
On Mon, 28 Feb 2022 23:17:57 GMT, Naoto Sato wrote: > Fixing the definition and implementation of the pattern symbol `F`. Although > it is an incompatible change, I believe it is worth the fix. For that, a CSR > has been drafted. Marked as reviewed by joehw (Reviewer). - PR: http

Re: RFR: 8282081: java.time.DateTimeFormatter: wrong definition of symbol F

2022-02-28 Thread Naoto Sato
On Tue, 1 Mar 2022 01:47:45 GMT, Joe Wang wrote: > Was the following assessment in the bug report correct? "the symbol F in > java.time.DateTimeFormatter is no use in any pattern. It just may cause an > exception." No, not correct. It is currently incorrectly tied with the `ChronoField.ALIGNE

Re: RFR: 8282081: java.time.DateTimeFormatter: wrong definition of symbol F

2022-02-28 Thread Joe Wang
On Mon, 28 Feb 2022 23:17:57 GMT, Naoto Sato wrote: > Fixing the definition and implementation of the pattern symbol `F`. Although > it is an incompatible change, I believe it is worth the fix. For that, a CSR > has been drafted. Was the following assessment in the bug report correct? "the

RFR: 8282081: java.time.DateTimeFormatter: wrong definition of symbol F

2022-02-28 Thread Naoto Sato
Fixing the definition and implementation of the pattern symbol `F`. Although it is an incompatible change, I believe it is worth the fix. For that, a CSR has been drafted. - Commit messages: - 8282081: java.time.DateTimeFormatter: wrong definition of symbol F Changes: https://git.