Re: RFR: 8284493: Fix rounding error in computeNextExponential [v2]

2022-06-06 Thread openjdk-notifier[bot]
On Thu, 2 Jun 2022 03:00:32 GMT, Chris Hennick wrote: >> Chris Hennick has refreshed the contents of this pull request, and previous >> commits have been removed. The incremental views will show differences >> compared to the previous content of the PR. The pull request contains one >> new com

Re: RFR: 8284493: Fix rounding error in computeNextExponential [v4]

2022-06-06 Thread Chris Hennick
> Repeatedly adding DoubleZigguratTables.exponentialX0 to extra causes a > rounding error to accumulate at the tail of the distribution (probably > starting around 2*exponentialX0 == 0x1.e46eff20739afp3 ~ 15.1); this fixes > that by tracking the multiple of exponentialX0 as a long. (This changes

Re: RFR: 8284493: Fix rounding error in computeNextExponential [v3]

2022-06-05 Thread Chris Hennick
> Repeatedly adding DoubleZigguratTables.exponentialX0 to extra causes a > rounding error to accumulate at the tail of the distribution (probably > starting around 2*exponentialX0 == 0x1.e46eff20739afp3 ~ 15.1); this fixes > that by tracking the multiple of exponentialX0 as a long. (This changes

Re: RFR: 8284493: Fix rounding error in computeNextExponential; use Math.fma(); use bounded version in computeNextGaussian [v2]

2022-06-01 Thread Chris Hennick
On Wed, 1 Jun 2022 22:53:14 GMT, Chris Hennick wrote: >> Repeatedly adding DoubleZigguratTables.exponentialX0 to extra causes a >> rounding error to accumulate at the tail of the distribution (probably >> starting around 2*exponentialX0 == 0x1.e46eff20739afp3 ~ 15.1); this fixes >> that by tra

Re: RFR: 8284493: Fix rounding error in computeNextExponential [v2]

2022-06-01 Thread Chris Hennick
On Wed, 1 Jun 2022 22:49:01 GMT, Chris Hennick wrote: >> @Pr0methean As @turbanoff observes, I think there's a closing parentheses >> too much on L.1411 and one on L.1421. >> Which compiler are you using ;-) ? > > Should be fixed as of fa340fb47b1169805f21fb71cce0da3fc175d427. I haven't yet >

Re: RFR: 8284493: Fix rounding error in computeNextExponential [v2]

2022-06-01 Thread Chris Hennick
> Repeatedly adding DoubleZigguratTables.exponentialX0 to extra causes a > rounding error to accumulate at the tail of the distribution (probably > starting around 2*exponentialX0 == 0x1.e46eff20739afp3 ~ 15.1); this fixes > that by tracking the multiple of exponentialX0 as a long. (This changes

Re: RFR: 8284493: Fix rounding error in computeNextExponential [v2]

2022-06-01 Thread Chris Hennick
On Mon, 23 May 2022 14:21:55 GMT, Raffaello Giulietti wrote: >> src/java.base/share/classes/jdk/internal/util/random/RandomSupport.java line >> 1411: >> >>> 1409: long U2 = (rng.nextLong() >>> 1); >>> 1410: // Compute the actual x-coordinate of the randomly >>>

Re: RFR: 8284493: Fix rounding error in computeNextExponential

2022-05-23 Thread Raffaello Giulietti
On Sun, 22 May 2022 20:19:38 GMT, Andrey Turbanov wrote: >> Repeatedly adding DoubleZigguratTables.exponentialX0 to extra causes a >> rounding error to accumulate at the tail of the distribution (probably >> starting around 2*exponentialX0 == 0x1.e46eff20739afp3 ~ 15.1); this fixes >> that by

Re: RFR: 8284493: Fix rounding error in computeNextExponential

2022-05-22 Thread Andrey Turbanov
On Wed, 6 Apr 2022 17:47:53 GMT, Chris Hennick wrote: > Repeatedly adding DoubleZigguratTables.exponentialX0 to extra causes a > rounding error to accumulate at the tail of the distribution (probably > starting around 2*exponentialX0 == 0x1.e46eff20739afp3 ~ 15.1); this fixes > that by trackin

Re: RFR: 8284493: Fix rounding error in computeNextExponential

2022-05-10 Thread Chris Hennick
On Wed, 6 Apr 2022 17:47:53 GMT, Chris Hennick wrote: > Repeatedly adding DoubleZigguratTables.exponentialX0 to extra causes a > rounding error to accumulate at the tail of the distribution (probably > starting around 2*exponentialX0 == 0x1.e46eff20739afp3); this fixes that by > tracking the m

Re: RFR: 8284493: Fix rounding error in computeNextExponential

2022-05-10 Thread Xin Liu
On Wed, 6 Apr 2022 17:47:53 GMT, Chris Hennick wrote: > Repeatedly adding DoubleZigguratTables.exponentialX0 to extra causes a > rounding error to accumulate at the tail of the distribution (probably > starting around 2*exponentialX0 == 0x1.e46eff20739afp3); this fixes that by > tracking the m

RFR: 8284493: Fix rounding error in computeNextExponential

2022-05-10 Thread Chris Hennick
Repeatedly adding DoubleZigguratTables.exponentialX0 to extra causes a rounding error to accumulate at the tail of the distribution (probably starting around 2*exponentialX0 == 0x1.e46eff20739afp3); this fixes that by tracking the multiple of exponentialX0 as a long. (This changes the maximum po