Re: RFR: 8284637: Improve String.join performance [v2]

2022-04-12 Thread XenoAmess
On Mon, 11 Apr 2022 21:35:39 GMT, XenoAmess wrote: >> 8284637: Improve String.join performance > > XenoAmess has updated the pull request incrementally with one additional > commit since the last revision: > > add jmh JMH results shows not worthy. closed. - PR: https://git.open

Re: RFR: 8284637: Improve String.join performance

2022-04-11 Thread Claes Redestad
On Fri, 8 Apr 2022 19:33:26 GMT, XenoAmess wrote: > 8284637: Improve String.join performance I think you can use or extend the existing `org.openjdk.bench.java.util.StringJoinerBench` JMH for this. Refer to [doc/testing.md](../tree/master/doc/testing.md) for setup help, but you should be able

Re: RFR: 8284637: Improve String.join performance

2022-04-11 Thread XenoAmess
On Mon, 11 Apr 2022 20:15:08 GMT, XenoAmess wrote: > Is there jmh test data to quantify the improvement? @RogerRiggs added jmh now. Is there any test suite to run it but not run other jmh tests? Or I must invoke the jmh jar using commandline myself to achieve it? - PR: https://gi

Re: RFR: 8284637: Improve String.join performance [v2]

2022-04-11 Thread XenoAmess
> 8284637: Improve String.join performance XenoAmess has updated the pull request incrementally with one additional commit since the last revision: add jmh - Changes: - all: https://git.openjdk.java.net/jdk/pull/8169/files - new: https://git.openjdk.java.net/jdk/pull/8169/fil

Re: RFR: 8284637: Improve String.join performance

2022-04-11 Thread XenoAmess
On Mon, 11 Apr 2022 19:22:21 GMT, Roger Riggs wrote: > Is there jmh test data to quantify the improvement? Not yet as I don't really know how to run a jmh for a package static function, who calls some other class private functions... Should I put the test upon StringJoiner insterad, as it call

Re: RFR: 8284637: Improve String.join performance

2022-04-11 Thread Roger Riggs
On Fri, 8 Apr 2022 19:33:26 GMT, XenoAmess wrote: > 8284637: Improve String.join performance src/java.base/share/classes/java/lang/String.java line 3290: > 3288: value, > 3289: off << coder, > 3290: delimiterLengthWithCoder

Re: RFR: 8284637: Improve String.join performance

2022-04-11 Thread Roger Riggs
On Fri, 8 Apr 2022 19:33:26 GMT, XenoAmess wrote: > 8284637: Improve String.join performance Is there jmh test data to quantify the improvement? Is there jmh test data to quantify the improvement? - PR: https://git.openjdk.java.net/jdk/pull/8169

Re: RFR: 8284637: Improve String.join performance

2022-04-11 Thread XenoAmess
On Mon, 11 Apr 2022 11:57:04 GMT, ExE Boss wrote: > The issue is now > [JDK‑8284637](https://bugs.openjdk.java.net/browse/JDK-8284637). Yes. Just got the time to update it. - PR: https://git.openjdk.java.net/jdk/pull/8169

Re: RFR: 8284637: Improve String.join performance

2022-04-11 Thread ExE Boss
On Fri, 8 Apr 2022 19:33:26 GMT, XenoAmess wrote: > 8284637: Improve String.join performance The issue is now [JDK‑8284637](https://bugs.openjdk.java.net/browse/JDK-8284637 "[JDK‑8284637] Improve String.join performance"). - PR: https://git.openjdk.java.net/jdk/pull/8169

RFR: 8284637: Improve String.join performance

2022-04-11 Thread XenoAmess
8284637: Improve String.join performance - Commit messages: - refine performance of String#join Changes: https://git.openjdk.java.net/jdk/pull/8169/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=8169&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8284637