Re: RFR: 8285001: Simplify StringLatin1.regionMatches

2022-04-19 Thread Claes Redestad
On Tue, 19 Apr 2022 08:50:09 GMT, Claes Redestad wrote: > There is no pair of character values in the latin1 range (0-255) that will > make the condition at line 401 in `StringLatin1.java` true, so this test can > be removed. > > Added a test and a microbenchmark (which as expected sees a few

Re: RFR: 8285001: Simplify StringLatin1.regionMatches [v2]

2022-04-19 Thread Claes Redestad
> There is no pair of character values in the latin1 range (0-255) that will > make the condition at line 401 in `StringLatin1.java` true, so this test can > be removed. > > Added a test and a microbenchmark (which as expected sees a few ns/op > improvement from this change). Took the opportuni

Re: RFR: 8285001: Simplify StringLatin1.regionMatches

2022-04-19 Thread Naoto Sato
On Tue, 19 Apr 2022 13:37:32 GMT, Roger Riggs wrote: > Nice Catch! +1 - PR: https://git.openjdk.java.net/jdk/pull/8292

Re: RFR: 8285001: Simplify StringLatin1.regionMatches

2022-04-19 Thread Naoto Sato
On Tue, 19 Apr 2022 08:50:09 GMT, Claes Redestad wrote: > There is no pair of character values in the latin1 range (0-255) that will > make the condition at line 401 in `StringLatin1.java` true, so this test can > be removed. > > Added a test and a microbenchmark (which as expected sees a few

Re: RFR: 8285001: Simplify StringLatin1.regionMatches

2022-04-19 Thread Roger Riggs
On Tue, 19 Apr 2022 08:50:09 GMT, Claes Redestad wrote: > There is no pair of character values in the latin1 range (0-255) that will > make the condition at line 401 in `StringLatin1.java` true, so this test can > be removed. > > Added a test and a microbenchmark (which as expected sees a few

RFR: 8285001: Simplify StringLatin1.regionMatches

2022-04-19 Thread Claes Redestad
There is no pair of character values in the latin1 range (0-255) that will make the condition at line 401 in `StringLatin1.java` true, so this test can be removed. Added a test and a microbenchmark (which as expected sees a few ns/op improvement from this change). Took the opportunity to tune t