Re: RFR: 8286560: Remove user parameter from jdk.internal.perf.Perf.attach() [v2]

2022-05-12 Thread Ioi Lam
On Thu, 12 May 2022 04:06:44 GMT, David Holmes wrote: >> Ioi Lam has updated the pull request incrementally with one additional >> commit since the last revision: >> >> @AlanBateman comments - remove thros IllegalArgumentException clause > > Nice cleanup! I checked back in JDK 7 and couldn't

Re: RFR: 8286560: Remove user parameter from jdk.internal.perf.Perf.attach() [v2]

2022-05-12 Thread Ioi Lam
On Thu, 12 May 2022 14:08:11 GMT, Alan Bateman wrote: >> Ioi Lam has updated the pull request incrementally with one additional >> commit since the last revision: >> >> @AlanBateman comments - remove thros IllegalArgumentException clause > >

Re: RFR: 8286560: Remove user parameter from jdk.internal.perf.Perf.attach() [v2]

2022-05-12 Thread Ioi Lam
> The API `jdk.internal.perf.Perf.::attach(String user, int lvmid)` is never > used. It should be removed, and all the handling of a specified user name > should be removed. Ioi Lam has updated the pull request incrementally with one additional commit since the last revision: @AlanBateman