On Fri, 3 Jun 2022 16:48:11 GMT, Jorn Vernee wrote:
>> I'm not so sure.
>>
>> First of all we're no worse than before with the defensive copying here.
>> Second of an optimizing compiler might theoretically be able to see that the
>> array we get from the toArray is always fresh and not escap
On Fri, 3 Jun 2022 16:43:37 GMT, Claes Redestad wrote:
>> The same could be done for the public `dropArgumentsToMatch` I think.
>
> I'm not so sure.
>
> First of all we're no worse than before with the defensive copying here.
> Second of an optimizing compiler might theoretically be able to se
On Fri, 3 Jun 2022 15:06:48 GMT, Jorn Vernee wrote:
>> Claes Redestad has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Review comments, eagerly convert sooner in tryFinally
>
> src/java.base/share/classes/java/lang/invoke/MethodHandles.ja
On Fri, 3 Jun 2022 15:18:52 GMT, Jorn Vernee wrote:
>> src/java.base/share/classes/java/lang/invoke/MethodHandles.java line 5266:
>>
>>> 5264: */
>>> 5265: public static MethodHandle dropArguments(MethodHandle target, int
>>> pos, List> valueTypes) {
>>> 5266: return dropArgume
On Fri, 3 Jun 2022 15:09:24 GMT, Jorn Vernee wrote:
>> Claes Redestad has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Review comments, eagerly convert sooner in tryFinally
>
> src/java.base/share/classes/java/lang/invoke/MethodHandles.ja
On Fri, 27 May 2022 19:52:30 GMT, Claes Redestad wrote:
>> In preparation of #8855 this PR refactors the conversions from `List` to
>> array and array to `List`, reducing the number of conversions when calling
>> `MethodHandles.dropArguments` in particular. This remove about ~5% of
>> allocati
On Thu, 2 Jun 2022 15:19:44 GMT, Сергей Цыпанов wrote:
>> The clone is needed - as the `List>` may be a custom implementation
>> of List - so you cannot make any assumption on the concrete implementation
>> of `toArray`.
>
> But we can make an assumption on the behavior of particular method and
On Thu, 2 Jun 2022 14:25:55 GMT, Daniel Fuchs wrote:
>> src/java.base/share/classes/java/lang/invoke/MethodHandles.java line 5462:
>>
>>> 5460: Objects.requireNonNull(target);
>>> 5461: Objects.requireNonNull(newTypes);
>>> 5462: return dropArgumentsToMatch(target, skip,
On Thu, 2 Jun 2022 13:59:50 GMT, Сергей Цыпанов wrote:
>> Claes Redestad has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Review comments, eagerly convert sooner in tryFinally
>
> src/java.base/share/classes/java/lang/invoke/MethodHandles
On Fri, 27 May 2022 19:52:30 GMT, Claes Redestad wrote:
>> In preparation of #8855 this PR refactors the conversions from `List` to
>> array and array to `List`, reducing the number of conversions when calling
>> `MethodHandles.dropArguments` in particular. This remove about ~5% of
>> allocati
> In preparation of #8855 this PR refactors the conversions from `List` to
> array and array to `List`, reducing the number of conversions when calling
> `MethodHandles.dropArguments` in particular. This remove about ~5% of
> allocations on the `StringConcatFactoryBootstraps` microbenchmark.
Cl
11 matches
Mail list logo
