Re: RFR: 8287522: StringConcatFactory: Add in prependers and mixers in batches [v7]

2022-06-03 Thread Remi Forax
- Original Message - > From: "Claes Redestad" > To: "core-libs-dev" > Sent: Friday, June 3, 2022 2:19:34 PM > Subject: Re: RFR: 8287522: StringConcatFactory: Add in prependers and mixers > in batches [v7] > On Fri, 3 Jun 2022 11:19:04 GMT, ExE Bo

Re: RFR: 8287522: StringConcatFactory: Add in prependers and mixers in batches [v7]

2022-06-03 Thread Claes Redestad
On Fri, 3 Jun 2022 11:19:04 GMT, ExE Boss wrote: >> You would think that, but javac doesn't do anything fancy once you store to >> a local >> >> javap output for lines 108 through 111: >> >>449: ldc #148// float 0.1f >>451: fstore31 >>4

Re: RFR: 8287522: StringConcatFactory: Add in prependers and mixers in batches [v7]

2022-06-03 Thread ExE Boss
On Thu, 2 Jun 2022 20:01:33 GMT, Claes Redestad wrote: >> make/jdk/src/classes/build/tools/classlist/HelloClasslist.java line 116: >> >>> 114: String CC = "string" + c; >>> 115: String CCS= "string" + c + s; >>> 116: String CSCC = "string" + s + "string" + c; >>

Re: RFR: 8287522: StringConcatFactory: Add in prependers and mixers in batches [v7]

2022-06-02 Thread Claes Redestad
On Thu, 2 Jun 2022 18:49:13 GMT, ExE Boss wrote: >> Claes Redestad has updated the pull request incrementally with one >> additional commit since the last revision: >> >> We now don't need big Species classes for shorter concats, so on some >> tests the improvements meant more Species class

Re: RFR: 8287522: StringConcatFactory: Add in prependers and mixers in batches [v7]

2022-06-02 Thread ExE Boss
On Thu, 2 Jun 2022 10:57:37 GMT, Claes Redestad wrote: >> When generating `MethodHandle`-based concatenation expressions in >> `StringConcatFactory` we can reduce the number of classes generated at >> runtime by creating small batches of prependers and mixers before binding >> them into the ro

Re: RFR: 8287522: StringConcatFactory: Add in prependers and mixers in batches [v7]

2022-06-02 Thread Claes Redestad
> When generating `MethodHandle`-based concatenation expressions in > `StringConcatFactory` we can reduce the number of classes generated at > runtime by creating small batches of prependers and mixers before binding > them into the root expression tree. > > Improvements on one-off tests are m