Re: RFR: 8920687: Deflater.setLevel does not work as expected

2013-09-15 Thread Xueming Shen
Thanks Alan. I dropped the current in setLevel. Yes, I would like to be explicit about the deflate invocation here, as the implementation clearly just calls the deflate() blindly with the old level/strategy after the level/strategy changed, regardless whether there is really anything in the

Re: RFR: 8920687: Deflater.setLevel does not work as expected

2013-09-15 Thread Alan Bateman
On 15/09/2013 19:30, Xueming Shen wrote: Thanks Alan. I dropped the current in setLevel. Yes, I would like to be explicit about the deflate invocation here, as the implementation clearly just calls the deflate() blindly with the old level/strategy after the level/strategy changed, regardless

Re: RFR: 8920687: Deflater.setLevel does not work as expected

2013-09-15 Thread Xueming Shen
Updated accordingly. http://cr.openjdk.java.net/~sherman/8020687/webrev/ Thanks! -Sherman On 9/15/13 12:45 PM, Alan Bateman wrote: On 15/09/2013 19:30, Xueming Shen wrote: Thanks Alan. I dropped the current in setLevel. Yes, I would like to be explicit about the deflate invocation here, as

Re: RFR: 8920687: Deflater.setLevel does not work as expected

2013-09-14 Thread Alan Bateman
On 13/09/2013 20:44, Xueming Shen wrote: Hi, This is change to clarify the java doc to match the existing behavior. If there is a pending level/strategy change (via setLevel/Stragety()) when deflate(...) is invoked, the implementation goes down to zlib's deflateParams() for deflating

RFR: 8920687: Deflater.setLevel does not work as expected

2013-09-13 Thread Xueming Shen
Hi, This is change to clarify the java doc to match the existing behavior. If there is a pending level/strategy change (via setLevel/Stragety()) when deflate(...) is invoked, the implementation goes down to zlib's deflateParams() for deflating operation, which clearly specifies its behavior