On Tue, 24 May 2022 16:20:10 GMT, Mark Powers wrote:
> Mach5 tier1 and tier2 completed without any failures. I don't know what to
> make of the pre-submit failures - lang and hotspot?
IIUC, these are due to Loom failures in some of the other platforms supported
by OpenJDK but not by Oracle.
On Mon, 23 May 2022 18:58:34 GMT, Mark Powers wrote:
>> JDK-6725221 Standardize obtaining boolean properties with defaults
>
> Mark Powers has updated the pull request with a new target base due to a
> merge or a rebase. The pull request now contains six commits:
>
> - Alan and Jamil comments
On Mon, 23 May 2022 18:58:34 GMT, Mark Powers wrote:
>> JDK-6725221 Standardize obtaining boolean properties with defaults
>
> Mark Powers has updated the pull request with a new target base due to a
> merge or a rebase. The pull request now contains six commits:
>
> - Alan and Jamil comments
On Mon, 23 May 2022 18:34:41 GMT, Roger Riggs wrote:
>> You are right. The old way maps the null string to true, and the new way
>> maps it to false. I did not notice that. At this point, I see no value in
>> making the "true".equals and "false".equals changes. Too much can break.
>> I'll
> JDK-6725221 Standardize obtaining boolean properties with defaults
Mark Powers has updated the pull request with a new target base due to a merge
or a rebase. The pull request now contains six commits:
- Alan and Jamil comments
- Merge
- reverse true.equals and false.equals changes
-
On Tue, 10 May 2022 19:24:24 GMT, Mark Powers wrote:
>> src/java.base/share/classes/java/lang/reflect/AccessibleObject.java line 777:
>>
>>> 775: if (!printStackPropertiesSet && VM.initLevel() >= 1) {
>>> 776: printStackWhenAccessFails = GetBooleanAction.
>>> 777:
On Fri, 6 May 2022 17:56:44 GMT, Alan Bateman wrote:
>> JDK-6725221 Standardize obtaining boolean properties with defaults
>
> src/java.base/share/classes/java/lang/reflect/AccessibleObject.java line 777:
>
>> 775: if (!printStackPropertiesSet && VM.initLevel() >= 1) {
>> 776:
On Sun, 8 May 2022 02:22:08 GMT, Phil Race wrote:
> I did wonder why it has security-libs as the sub-category and if the intent
> was not what we see here.
I suspect the JBS issue was initially created to to look at the usages of
getProperty in the security code but it has been extended. The
On Thu, 5 May 2022 16:49:07 GMT, Mark Powers wrote:
> JDK-6725221 Standardize obtaining boolean properties with defaults
I did wonder why it has security-libs as the sub-category and if the intent was
not what we see here.
-
PR: https://git.openjdk.java.net/jdk/pull/8559
On Thu, 5 May 2022 16:49:07 GMT, Mark Powers wrote:
> JDK-6725221 Standardize obtaining boolean properties with defaults
Sorry for the confusion.
The original intent of this bug 14 years ago was to standardize the seclibs
code where simple getProperty calls were needed in the context of an
On Thu, 5 May 2022 16:49:07 GMT, Mark Powers wrote:
> JDK-6725221 Standardize obtaining boolean properties with defaults
The xtoolkit change is fine. I've not looked at anything else
You'll clearly need multiple reviewers for this one.
-
Marked as reviewed by prr (Reviewer).
PR:
On Thu, 5 May 2022 16:49:07 GMT, Mark Powers wrote:
> JDK-6725221 Standardize obtaining boolean properties with defaults
src/java.base/share/classes/java/lang/reflect/AccessibleObject.java line 777:
> 775: if (!printStackPropertiesSet && VM.initLevel() >= 1) {
> 776:
JDK-6725221 Standardize obtaining boolean properties with defaults
-
Commit messages:
- Merge
- first iteration
Changes: https://git.openjdk.java.net/jdk/pull/8559/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk=8559=00
Issue:
13 matches
Mail list logo
