Re: RFR: JDK-8058407: Remove Multiple JRE support in the Java launcher

2014-12-07 Thread Alan Bateman
On 07/12/2014 16:08, Kumar Srinivasan wrote: Alan, Highlights: * Fixed the indenting in java.c around JLI_ReportErrorMessage(SPC_ERROR2) * Fixed parse_manifest.c, removed the redundant check, also added some braces to that if/else/elseif block for consistency sake. * Updated CopyRights as w

Re: RFR: JDK-8058407: Remove Multiple JRE support in the Java launcher

2014-12-07 Thread Kumar Srinivasan
Alan, Highlights: * Fixed the indenting in java.c around JLI_ReportErrorMessage(SPC_ERROR2) * Fixed parse_manifest.c, removed the redundant check, also added some braces to that if/else/elseif block for consistency sake. * Updated CopyRights as well. The changes to the last webrev are here:

Re: RFR: JDK-8058407: Remove Multiple JRE support in the Java launcher

2014-12-06 Thread Alan Bateman
On 05/12/2014 15:22, Kumar Srinivasan wrote: Hello, Please review the fix for JDK-8058407, contributed by Neil Toda, described by JEP 231 [1] the webrev is at: http://cr.openjdk.java.net/~ksrini/8058407/webrev.00/ Please note: The above webrev is identical to the original posted by Neal at

Re: RFR: JDK-8058407: Remove Multiple JRE support in the Java launcher

2014-12-05 Thread joe darcy
Looks good, -Joe On 12/5/2014 7:22 AM, Kumar Srinivasan wrote: Hello, Please review the fix for JDK-8058407, contributed by Neil Toda, described by JEP 231 [1] the webrev is at: http://cr.openjdk.java.net/~ksrini/8058407/webrev.00/ Please note: The above webrev is identical to the original

RFR: JDK-8058407: Remove Multiple JRE support in the Java launcher

2014-12-05 Thread Kumar Srinivasan
Hello, Please review the fix for JDK-8058407, contributed by Neil Toda, described by JEP 231 [1] the webrev is at: http://cr.openjdk.java.net/~ksrini/8058407/webrev.00/ Please note: The above webrev is identical to the original posted by Neal at http://cr.openjdk.java.net/~ntoda/8058407/webrev