Re: RFR: JDK-8068682 - Deprivilege/move java.corba to the ext class loader

2015-02-10 Thread Mandy Chung
The change without ORB.java looks okay to me. Mandy On 2/10/15 4:11 AM, Mark Sheppard wrote: OK I'll remove it. I thought that property files had been migrated from lib to conf, as per conf/security, so I made the change regards Mark On 10/02/2015 11:37, Alan Bateman wrote: On 10/02/2015

Re: RFR: JDK-8068682 - Deprivilege/move java.corba to the ext class loader

2015-02-10 Thread Alan Bateman
On 07/02/2015 00:22, Mark Sheppard wrote: Hi Alan, I had meant to remove the commented lines prior to generating the patch Okay, so ignoring that part then the rest looks good to me. Hopefully we have enough tests in this area that run with a security manager to help find any issues.

Re: RFR: JDK-8068682 - Deprivilege/move java.corba to the ext class loader

2015-02-10 Thread Alan Bateman
On 10/02/2015 11:20, Mark Sheppard wrote: thanks Alan the updated corba part is at http://cr.openjdk.java.net/~msheppar/8068682/corba/webrev.02/ I assume ORB.java isn't meant to be in this webrev (the lib-conf issue is separate and I think will need an @implNote in additional to checking

Re: RFR: JDK-8068682 - Deprivilege/move java.corba to the ext class loader

2015-02-10 Thread Mark Sheppard
thanks Alan the updated corba part is at http://cr.openjdk.java.net/~msheppar/8068682/corba/webrev.02/ regards Mark On 10/02/2015 09:14, Alan Bateman wrote: On 07/02/2015 00:22, Mark Sheppard wrote: Hi Alan, I had meant to remove the commented lines prior to generating the patch Okay,

Re: RFR: JDK-8068682 - Deprivilege/move java.corba to the ext class loader

2015-02-10 Thread Mark Sheppard
OK I'll remove it. I thought that property files had been migrated from lib to conf, as per conf/security, so I made the change regards Mark On 10/02/2015 11:37, Alan Bateman wrote: On 10/02/2015 11:20, Mark Sheppard wrote: thanks Alan the updated corba part is at

Re: RFR: JDK-8068682 - Deprivilege/move java.corba to the ext class loader

2015-02-09 Thread Alan Bateman
On 08/02/2015 06:58, Mandy Chung wrote: : Mark's patch is first to move it out from the boot loader to the ext class loader. Identifying the permissions required by corba requires more effort and not straight-forward. So it's granted with AllPermissions for now and reduce the permission

Re: RFR: JDK-8068682 - Deprivilege/move java.corba to the ext class loader

2015-02-07 Thread David Holmes
On 7/02/2015 4:55 AM, Mark Sheppard wrote: Hi please oblige and review the following changes http://cr.openjdk.java.net/~msheppar/8068682/webrev/ http://cr.openjdk.java.net/~msheppar/8068682/corba/webrev/ which address the issue in https://bugs.openjdk.java.net/browse/JDK-8068682 this

Re: RFR: JDK-8068682 - Deprivilege/move java.corba to the ext class loader

2015-02-07 Thread Mandy Chung
On 2/7/2015 5:10 PM, David Holmes wrote: On 7/02/2015 4:55 AM, Mark Sheppard wrote: Hi please oblige and review the following changes http://cr.openjdk.java.net/~msheppar/8068682/webrev/ http://cr.openjdk.java.net/~msheppar/8068682/corba/webrev/ which address the issue in

Re: RFR: JDK-8068682 - Deprivilege/move java.corba to the ext class loader

2015-02-06 Thread Alan Bateman
On 06/02/2015 18:55, Mark Sheppard wrote: Hi please oblige and review the following changes http://cr.openjdk.java.net/~msheppar/8068682/webrev/ http://cr.openjdk.java.net/~msheppar/8068682/corba/webrev/ which address the issue in https://bugs.openjdk.java.net/browse/JDK-8068682 this change

Re: RFR: JDK-8068682 - Deprivilege/move java.corba to the ext class loader

2015-02-06 Thread Mark Sheppard
Hi Alan, I had meant to remove the commented lines prior to generating the patch regards Mark On 06/02/2015 21:21, Alan Bateman wrote: On 06/02/2015 18:55, Mark Sheppard wrote: Hi please oblige and review the following changes http://cr.openjdk.java.net/~msheppar/8068682/webrev/

RFR: JDK-8068682 - Deprivilege/move java.corba to the ext class loader

2015-02-06 Thread Mark Sheppard
Hi please oblige and review the following changes http://cr.openjdk.java.net/~msheppar/8068682/webrev/ http://cr.openjdk.java.net/~msheppar/8068682/corba/webrev/ which address the issue in https://bugs.openjdk.java.net/browse/JDK-8068682 this change means CORBA ORB is loaded by the extension