Re: RFR: JDK-8072842 Add support for building native JTReg tests

2015-02-27 Thread Jonathan Gibbons
On 02/10/2015 07:10 AM, Staffan Larsen wrote: To clarify: The restriction in jtreg is that all tests are loaded in separate class loaders (when running in samevm mode). A native library can only be loaded in one class loader at a time. So if two tests tries to load the same library we get

Re: RFR: JDK-8072842 Add support for building native JTReg tests

2015-02-27 Thread Magnus Ihse Bursie
On 2015-02-26 10:25, Erik Joelsson wrote: Hello Magnus, Overall looks good. I would prefer if some of the longer lines in Main.gmk were split as it's a file I often need to read. In MakeBase, the definition of dups, I thought we (informally) agreed to start such macro definitions with a

Re: RFR: JDK-8072842 Add support for building native JTReg tests

2015-02-26 Thread Staffan Larsen
As far as I can tell (I’m not a makefile expert) this looks good. Thanks, /Staffan On 25 feb 2015, at 12:21, Magnus Ihse Bursie magnus.ihse.bur...@oracle.com wrote: On 2015-02-11 13:08, Staffan Larsen wrote: Okay so if I just cd into hotspot/test and use the Makefile to try and run

Re: RFR: JDK-8072842 Add support for building native JTReg tests

2015-02-26 Thread Erik Joelsson
Hello Magnus, Overall looks good. I would prefer if some of the longer lines in Main.gmk were split as it's a file I often need to read. In MakeBase, the definition of dups, I thought we (informally) agreed to start such macro definitions with a newline to make them stand out more from normal

Re: RFR: JDK-8072842 Add support for building native JTReg tests

2015-02-25 Thread Magnus Ihse Bursie
On 2015-02-11 13:08, Staffan Larsen wrote: Okay so if I just cd into hotspot/test and use the Makefile to try and run some jtreg tests it looks to me that it will define an invalid -nativepath I'm not sure if that is a supported use case. David or Staffan will have to answer to that. I have

Re: RFR: JDK-8072842 Add support for building native JTReg tests

2015-02-11 Thread Staffan Larsen
On 11 feb 2015, at 09:39, David Holmes david.hol...@oracle.com wrote: On 11/02/2015 6:34 PM, Staffan Larsen wrote: On 11 feb 2015, at 09:27, Magnus Ihse Bursie magnus.ihse.bur...@oracle.com mailto:magnus.ihse.bur...@oracle.com wrote: On 2015-02-11 09:23, David Holmes wrote: On

Re: RFR: JDK-8072842 Add support for building native JTReg tests

2015-02-11 Thread Magnus Ihse Bursie
On 2015-02-11 09:23, David Holmes wrote: On 11/02/2015 6:09 PM, Magnus Ihse Bursie wrote: On 2015-02-11 02:35, David Holmes wrote: Hi Magnus, On 11/02/2015 12:23 AM, Magnus Ihse Bursie wrote: Here is an addition to the build system, that will compile native libraries and executables and make

Re: RFR: JDK-8072842 Add support for building native JTReg tests

2015-02-11 Thread Staffan Larsen
On 11 feb 2015, at 09:27, Magnus Ihse Bursie magnus.ihse.bur...@oracle.com wrote: On 2015-02-11 09:23, David Holmes wrote: On 11/02/2015 6:09 PM, Magnus Ihse Bursie wrote: On 2015-02-11 02:35, David Holmes wrote: Hi Magnus, On 11/02/2015 12:23 AM, Magnus Ihse Bursie wrote: Here is an

Re: RFR: JDK-8072842 Add support for building native JTReg tests

2015-02-11 Thread David Holmes
On 11/02/2015 6:34 PM, Staffan Larsen wrote: On 11 feb 2015, at 09:27, Magnus Ihse Bursie magnus.ihse.bur...@oracle.com mailto:magnus.ihse.bur...@oracle.com wrote: On 2015-02-11 09:23, David Holmes wrote: On 11/02/2015 6:09 PM, Magnus Ihse Bursie wrote: On 2015-02-11 02:35, David Holmes

Re: RFR: JDK-8072842 Add support for building native JTReg tests

2015-02-11 Thread David Holmes
On 11/02/2015 6:09 PM, Magnus Ihse Bursie wrote: On 2015-02-11 02:35, David Holmes wrote: Hi Magnus, On 11/02/2015 12:23 AM, Magnus Ihse Bursie wrote: Here is an addition to the build system, that will compile native libraries and executables and make them available for JTReg tests written in

Re: RFR: JDK-8072842 Add support for building native JTReg tests

2015-02-11 Thread Magnus Ihse Bursie
On 2015-02-11 02:35, David Holmes wrote: Hi Magnus, On 11/02/2015 12:23 AM, Magnus Ihse Bursie wrote: Here is an addition to the build system, that will compile native libraries and executables and make them available for JTReg tests written in Java. Sorry I'm missing the basics here: when

Re: RFR: JDK-8072842 Add support for building native JTReg tests

2015-02-11 Thread Staffan Larsen
On 11 feb 2015, at 12:15, David Holmes david.hol...@oracle.com wrote: On 11/02/2015 8:36 PM, Staffan Larsen wrote: On 11 feb 2015, at 09:39, David Holmes david.hol...@oracle.com wrote: On 11/02/2015 6:34 PM, Staffan Larsen wrote: On 11 feb 2015, at 09:27, Magnus Ihse Bursie

Re: RFR: JDK-8072842 Add support for building native JTReg tests

2015-02-11 Thread David Holmes
On 11/02/2015 8:36 PM, Staffan Larsen wrote: On 11 feb 2015, at 09:39, David Holmes david.hol...@oracle.com wrote: On 11/02/2015 6:34 PM, Staffan Larsen wrote: On 11 feb 2015, at 09:27, Magnus Ihse Bursie magnus.ihse.bur...@oracle.com mailto:magnus.ihse.bur...@oracle.com wrote: On

Re: RFR: JDK-8072842 Add support for building native JTReg tests

2015-02-10 Thread Staffan Larsen
On 10 feb 2015, at 15:23, Magnus Ihse Bursie magnus.ihse.bur...@oracle.com wrote: Here is an addition to the build system, that will compile native libraries and executables and make them available for JTReg tests written in Java. This patch is the result of the work (in serial,

Re: RFR: JDK-8072842 Add support for building native JTReg tests

2015-02-10 Thread Magnus Ihse Bursie
10 feb 2015 kl. 16:10 skrev Staffan Larsen staffan.lar...@oracle.com: On 10 feb 2015, at 15:23, Magnus Ihse Bursie magnus.ihse.bur...@oracle.com wrote: Here is an addition to the build system, that will compile native libraries and executables and make them available for JTReg tests

RFR: JDK-8072842 Add support for building native JTReg tests

2015-02-10 Thread Magnus Ihse Bursie
Here is an addition to the build system, that will compile native libraries and executables and make them available for JTReg tests written in Java. This patch is the result of the work (in serial, mostly) of Staffan Larsen, David Simms and me. (And possible more that I don't know about.)

Re: RFR: JDK-8072842 Add support for building native JTReg tests

2015-02-10 Thread David Holmes
Hi Magnus, On 11/02/2015 12:23 AM, Magnus Ihse Bursie wrote: Here is an addition to the build system, that will compile native libraries and executables and make them available for JTReg tests written in Java. Sorry I'm missing the basics here: when does this compilation take place? As part